Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Disable pool collapsing #307

Merged
merged 3 commits into from
Mar 21, 2022
Merged

[FEAT] Disable pool collapsing #307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
918b4cb
[FEAT] Disable pool collapsing
tbouffard Mar 18, 2022
3788f71
fix extra reformatting
tbouffard Mar 18, 2022
406eb9f
Hide radio buttons as we can only hide other pools (no more action se…
tbouffard Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion examples/custom-behavior/select-elements-by-bpmn-kind/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
<div class="col-12 mb-2">
<h2>Select elements by BPMN kind</h2>
Once the BPMN diagram is loaded, detect all <code>Pools</code> and <code>End Events</code>.<br>
Then, use this information to select <code>Pools</code> (hide or collapse) and make <code>End Events</code> clickable
Then, use this information to select <code>Pools</code> (hide others) and make <code>End Events</code> clickable
(as far as no <code>Pools</code> selection is done. Toast support <a href="https://github.com/caroso1222/notyf">Notyf</a>).
</div>
<div id="controls" style="margin-top: 25px" >
Expand All @@ -111,6 +111,7 @@ <h2>Select elements by BPMN kind</h2>
<ul class="menu custom-dropdown" id="dropdown-select-pool">
</ul>
</div>
<!-- Disable collapsing: see https://github.com/process-analytics/bpmn-visualization-examples/pull/306
<div class="col-3 float-left">
<div class="align-middle">
<div class="radio">
Expand All @@ -121,6 +122,7 @@ <h2>Select elements by BPMN kind</h2>
</div>
</div>
</div>
-->
<div id="pool-selection-info" class="col-5 float-left hidden">
<b>Last selected Pool:</b> <span id="last-selected-pool-name"></span>
</div>
Expand Down
4 changes: 3 additions & 1 deletion examples/custom-behavior/select-elements-by-bpmn-kind/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,9 @@ function changePoolsVisibility(pools, poolIdToHighlight) {
console.info('Updating model, pool to highlight:', poolIdToHighlight);
const model = bpmnVisualization.graph.getModel();

const poolSelectionMethod = getRadioGroupValue('poolSelectionMethod');
// TMP disable collapsing other pools, see https://github.com/process-analytics/bpmn-visualization-examples/pull/306
// const poolSelectionMethod = getRadioGroupValue('poolSelectionMethod');
const poolSelectionMethod = 'hide';
console.info('Selection method:', poolSelectionMethod);
const hideOthers = poolSelectionMethod === 'hide';
const modelChangeFunction = hideOthers ?
Expand Down