Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Test the alternative terminal point implementation for 'no orthogonal segments' #306

Closed

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Mar 15, 2022

@tbouffard
Copy link
Member Author

tbouffard commented Mar 15, 2022

First implementation issue c47d25a

Issue with the implementation of from process-analytics/bpmn-visualization-js@b042a98. This is reproduced with a dedicated visual test in process-analytics/bpmn-visualization-js#1863 as well.

When collapsing a pool, the message flow terminal waypoint is still on the hidden shape with the collapsed pool instead of targeting the pool itself.
The implementation should probably use the "terminal port" instead, see https://jgraph.github.io/mxgraph/docs/js-api/files/util/mxConstants-js.html#mxConstants.STYLE_SOURCE_PORT.

expected current
collapsed_pool_expected collapsed_pool_msg_flow_still_targeting_inner_hidden_elements

@tbouffard
Copy link
Member Author

Tests completed. It helps us detecting that we must disable the collapsing feature from the example. See process-analytics/bpmn-visualization-js#1863 (comment).
So closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant