Refine test framework code and tests #5261

Willendless · 2022-06-30T13:27:46Z

What problem does this PR solve?

Issue Number: close #5262

Problem Summary:

What is changed and how it works?

introduce two separate macros (ASSERT_COLUMNS_EQ_R/UR) to test executors. ASSERT_COLUMNS_EQ_UR allows equality checking in unstable situation. It achieves this by converting both expected and actual cols to rows then inserting them to separate std::multiset and do comparison. On the other hand, ASSERT_COLUMNS_EQ_R requires more restrict equality checking, namely each column's every element and their offset should be the same.
remove the expected_cols argument from execute_streams() and force to compare equality only in unit test file. This step allows more useful (file name:line number) output message when test fails.
update old tests according to above modification

One failure example output using ASSERT_COLUMNS_EQ_UR is like

/tiflash/dbms/src/Flash/tests/gtest_join_executor.cpp:167: Failure
Value of: DB::tests::columnsEqual((executeStreams(request, 5)), (ans), false)
  Actual: false (Columns row set mismatch
expected_row_set:
'1' '3' '1' '3' 
'3' '4' '2' '4' 
...
actual_row_set:
'1' '3' '1' '3' 
'2' '4' '2' '4' 
...
)
Expected: true

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Since c/c++ preprocessor recognizes {col0, col1, col2} as multiple input arguments for function-like macros, while using ASSERT_COLUMNS_EQ_R/UR, we need to wrap these columns with createColumns(), i.e. createColumns({col0, col1, col2});

Documentation

Release note

None

ti-chi-bot · 2022-06-30T13:27:49Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

SeaRise
ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Willendless · 2022-06-30T14:10:07Z

/run-all-tests

sre-bot · 2022-06-30T14:27:58Z

Coverage for changed files

Filename                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp                           318               112    64.78%           5                 0   100.00%         174                 0   100.00%          88                48    45.45%
Flash/tests/gtest_limit_executor.cpp                      52                22    57.69%           3                 0   100.00%          29                 0   100.00%          18                 7    61.11%
Flash/tests/gtest_projection_executor.cpp                 97                41    57.73%           5                 0   100.00%         114                 0   100.00%          18                11    38.89%
Flash/tests/gtest_topn_executor.cpp                      219                63    71.23%           5                 0   100.00%         132                 2    98.48%          70                32    54.29%
TestUtils/ExecutorTestUtils.cpp                           68                 8    88.24%          12                 1    91.67%          99                 5    94.95%          26                 6    76.92%
TestUtils/ExecutorTestUtils.h                              6                 2    66.67%           3                 0   100.00%          18                 6    66.67%           6                 3    50.00%
TestUtils/FunctionTestUtils.cpp                          139                23    83.45%          17                 0   100.00%         203                24    88.18%          72                21    70.83%
TestUtils/FunctionTestUtils.h                            116                 9    92.24%          36                 0   100.00%         273                 7    97.44%          48                 6    87.50%
WindowFunctions/tests/gtest_window_functions.cpp         250                55    78.00%           2                 0   100.00%         131                 0   100.00%          76                39    48.68%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                   1265               335    73.52%          88                 1    98.86%        1173                44    96.25%         422               173    59.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18408      9612             47.78%    207073  96341        53.47%

full coverage report (for internal network access only)

Willendless · 2022-06-30T14:40:57Z

/cc @ywqzzy /cc @SeaRise /cc @xzhangxian1008

ti-chi-bot · 2022-06-30T14:41:00Z

@Willendless: GitHub didn't allow me to request PR reviews from the following users: /cc, xzhangxian1008.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @ywqzzy /cc @SeaRise /cc @xzhangxian1008

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Willendless · 2022-06-30T21:53:21Z

/run-all-tests

sre-bot · 2022-06-30T22:11:09Z

Coverage for changed files

Filename                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp                           318               112    64.78%           5                 0   100.00%         174                 0   100.00%          88                48    45.45%
Flash/tests/gtest_limit_executor.cpp                      52                22    57.69%           3                 0   100.00%          29                 0   100.00%          18                 7    61.11%
Flash/tests/gtest_projection_executor.cpp                 97                41    57.73%           5                 0   100.00%         114                 0   100.00%          18                11    38.89%
Flash/tests/gtest_topn_executor.cpp                      219                63    71.23%           5                 0   100.00%         132                 2    98.48%          70                32    54.29%
TestUtils/ExecutorTestUtils.cpp                           68                 8    88.24%          12                 1    91.67%          99                 5    94.95%          26                 6    76.92%
TestUtils/ExecutorTestUtils.h                              6                 2    66.67%           3                 0   100.00%          18                 6    66.67%           6                 3    50.00%
TestUtils/FunctionTestUtils.cpp                          139                23    83.45%          17                 0   100.00%         203                24    88.18%          72                21    70.83%
TestUtils/FunctionTestUtils.h                            116                 9    92.24%          36                 0   100.00%         273                 7    97.44%          48                 6    87.50%
WindowFunctions/tests/gtest_window_functions.cpp         250                55    78.00%           2                 0   100.00%         131                 0   100.00%          76                39    48.68%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                   1265               335    73.52%          88                 1    98.86%        1173                44    96.25%         422               173    59.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18408      9612             47.78%    207073  96334        53.48%

full coverage report (for internal network access only)

Willendless · 2022-06-30T23:30:21Z

/run-all-tests

sre-bot · 2022-06-30T23:47:58Z

Coverage for changed files

Filename                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp                           318               112    64.78%           5                 0   100.00%         174                 0   100.00%          88                48    45.45%
Flash/tests/gtest_limit_executor.cpp                      52                22    57.69%           3                 0   100.00%          29                 0   100.00%          18                 7    61.11%
Flash/tests/gtest_projection_executor.cpp                 97                41    57.73%           5                 0   100.00%         114                 0   100.00%          18                11    38.89%
Flash/tests/gtest_topn_executor.cpp                      219                63    71.23%           5                 0   100.00%         132                 2    98.48%          70                32    54.29%
TestUtils/ExecutorTestUtils.cpp                           68                 8    88.24%          12                 1    91.67%          99                 5    94.95%          26                 6    76.92%
TestUtils/ExecutorTestUtils.h                              6                 2    66.67%           3                 0   100.00%          18                 6    66.67%           6                 3    50.00%
TestUtils/FunctionTestUtils.cpp                          149                33    77.85%          18                 1    94.44%         238                59    75.21%          80                29    63.75%
TestUtils/FunctionTestUtils.h                            116                 9    92.24%          36                 0   100.00%         273                 7    97.44%          48                 6    87.50%
WindowFunctions/tests/gtest_window_functions.cpp         250                55    78.00%           2                 0   100.00%         131                 0   100.00%          76                39    48.68%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                   1275               345    72.94%          89                 2    97.75%        1208                79    93.46%         430               181    57.91%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18412      9617             47.77%    207113  96333        53.49%

full coverage report (for internal network access only)

dbms/src/TestUtils/FunctionTestUtils.cpp

dbms/src/Flash/tests/gtest_projection_executor.cpp

Willendless · 2022-07-01T19:38:47Z

/run-all-tests

sre-bot · 2022-07-01T19:56:53Z

Coverage for changed files

Filename                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp                           318               112    64.78%           5                 0   100.00%         174                 0   100.00%          88                48    45.45%
Flash/tests/gtest_limit_executor.cpp                      52                22    57.69%           3                 0   100.00%          29                 0   100.00%          18                 7    61.11%
Flash/tests/gtest_projection_executor.cpp                 97                41    57.73%           5                 0   100.00%         114                 0   100.00%          18                11    38.89%
Flash/tests/gtest_topn_executor.cpp                      219                63    71.23%           5                 0   100.00%         132                 2    98.48%          70                32    54.29%
TestUtils/ExecutorTestUtils.cpp                           68                 8    88.24%          12                 1    91.67%          99                 5    94.95%          26                 6    76.92%
TestUtils/ExecutorTestUtils.h                              6                 2    66.67%           3                 0   100.00%          18                 6    66.67%           6                 3    50.00%
TestUtils/FunctionTestUtils.cpp                          149                33    77.85%          19                 2    89.47%         234                55    76.50%          78                27    65.38%
TestUtils/FunctionTestUtils.h                            116                 9    92.24%          36                 0   100.00%         273                 7    97.44%          48                 6    87.50%
WindowFunctions/tests/gtest_window_functions.cpp         250                55    78.00%           2                 0   100.00%         131                 0   100.00%          76                39    48.68%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                   1275               345    72.94%          90                 3    96.67%        1204                75    93.77%         428               179    58.18%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18413      9617             47.77%    207109  96369        53.47%

full coverage report (for internal network access only)

SeaRise

LGTM

ywqzzy

Others LGTM

dbms/src/TestUtils/FunctionTestUtils.cpp

ywqzzy · 2022-07-04T08:09:36Z

dbms/src/TestUtils/FunctionTestUtils.cpp

+    return ::testing::AssertionSuccess();
+}
+
+/// @pre size of each column should be the same


pre?What does it mean

Oh, it might not be a good idea to add "@pre". I will remove it. It actually means precondition.

dbms/src/TestUtils/ExecutorTestUtils.cpp

Willendless · 2022-07-04T16:30:11Z

/run-all-tests

sre-bot · 2022-07-04T16:48:16Z

Coverage for changed files

Filename                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp                           318               112    64.78%           5                 0   100.00%         174                 0   100.00%          88                48    45.45%
Flash/tests/gtest_limit_executor.cpp                      52                22    57.69%           3                 0   100.00%          29                 0   100.00%          18                 7    61.11%
Flash/tests/gtest_projection_executor.cpp                 97                41    57.73%           5                 0   100.00%         114                 0   100.00%          18                11    38.89%
Flash/tests/gtest_topn_executor.cpp                      219                63    71.23%           5                 0   100.00%         132                 2    98.48%          70                32    54.29%
TestUtils/ExecutorTestUtils.cpp                           68                 8    88.24%          12                 1    91.67%          99                 5    94.95%          26                 6    76.92%
TestUtils/ExecutorTestUtils.h                              6                 2    66.67%           3                 0   100.00%          18                 6    66.67%           6                 3    50.00%
TestUtils/FunctionTestUtils.cpp                          149                33    77.85%          19                 2    89.47%         234                55    76.50%          78                27    65.38%
TestUtils/FunctionTestUtils.h                            116                 9    92.24%          36                 0   100.00%         273                 7    97.44%          48                 6    87.50%
WindowFunctions/tests/gtest_window_functions.cpp         250                55    78.00%           2                 0   100.00%         131                 0   100.00%          76                39    48.68%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                   1275               345    72.94%          90                 3    96.67%        1204                75    93.77%         428               179    58.18%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18413      9617             47.77%    207109  96411        53.45%

full coverage report (for internal network access only)

Willendless · 2022-07-06T12:29:15Z

/run-all-tests

sre-bot · 2022-07-06T12:48:37Z

Coverage for changed files

Filename                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp                           318               112    64.78%           5                 0   100.00%         174                 0   100.00%          88                48    45.45%
Flash/tests/gtest_limit_executor.cpp                      52                22    57.69%           3                 0   100.00%          29                 0   100.00%          18                 7    61.11%
Flash/tests/gtest_projection_executor.cpp                 97                41    57.73%           5                 0   100.00%         114                 0   100.00%          18                11    38.89%
Flash/tests/gtest_topn_executor.cpp                      219                63    71.23%           5                 0   100.00%         132                 2    98.48%          70                32    54.29%
TestUtils/ExecutorTestUtils.cpp                           68                 8    88.24%          12                 1    91.67%          99                 5    94.95%          26                 6    76.92%
TestUtils/ExecutorTestUtils.h                              6                 2    66.67%           3                 0   100.00%          18                 6    66.67%           6                 3    50.00%
TestUtils/FunctionTestUtils.cpp                          149                33    77.85%          19                 2    89.47%         234                55    76.50%          78                27    65.38%
TestUtils/FunctionTestUtils.h                            116                 9    92.24%          36                 0   100.00%         273                 7    97.44%          48                 6    87.50%
WindowFunctions/tests/gtest_window_functions.cpp         250                55    78.00%           2                 0   100.00%         131                 0   100.00%          76                39    48.68%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                   1275               345    72.94%          90                 3    96.67%        1204                75    93.77%         428               179    58.18%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18423      9625             47.76%    207316  96487        53.46%

full coverage report (for internal network access only)

SeaRise · 2022-07-06T14:53:54Z

/merge

ti-chi-bot · 2022-07-06T14:53:57Z

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-07-06T14:53:59Z

This pull request has been accepted and is ready to merge.

Commit hash: 778275e

sre-bot · 2022-07-06T15:04:37Z

Coverage for changed files

Filename                                             Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/tests/gtest_executor.cpp                           318               112    64.78%           5                 0   100.00%         174                 0   100.00%          88                48    45.45%
Flash/tests/gtest_limit_executor.cpp                      52                22    57.69%           3                 0   100.00%          29                 0   100.00%          18                 7    61.11%
Flash/tests/gtest_projection_executor.cpp                 97                41    57.73%           5                 0   100.00%         114                 0   100.00%          18                11    38.89%
Flash/tests/gtest_topn_executor.cpp                      219                63    71.23%           5                 0   100.00%         132                 2    98.48%          70                32    54.29%
TestUtils/ExecutorTestUtils.cpp                           68                 8    88.24%          12                 1    91.67%          99                 5    94.95%          26                 6    76.92%
TestUtils/ExecutorTestUtils.h                              6                 2    66.67%           3                 0   100.00%          18                 6    66.67%           6                 3    50.00%
TestUtils/FunctionTestUtils.cpp                          149                33    77.85%          19                 2    89.47%         234                55    76.50%          78                27    65.38%
TestUtils/FunctionTestUtils.h                            116                 9    92.24%          36                 0   100.00%         273                 7    97.44%          48                 6    87.50%
WindowFunctions/tests/gtest_window_functions.cpp         250                55    78.00%           2                 0   100.00%         131                 0   100.00%          76                39    48.68%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                   1275               345    72.94%          90                 3    96.67%        1204                75    93.77%         428               179    58.18%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18423      9625             47.76%    207316  96522        53.44%

full coverage report (for internal network access only)

…s in README (pingcap#5182) close pingcap#5172, ref pingcap#5178 Enhancement: add a integrated test on DDL module (pingcap#5130) ref pingcap#5129 Revert "Revise default background threads size" (pingcap#5176) close pingcap#5177 chore: remove extra dyn cast (pingcap#5186) close pingcap#5185 Add MPPReceiverSet, which includes ExchangeReceiver and CoprocessorReader (pingcap#5175) ref pingcap#5095 DDL: Use Column Name Instead of Offset to Find the common handle cluster index (pingcap#5166) close pingcap#5154 Add random failpoint in critical paths (pingcap#4876) close pingcap#4807 Segment test framework (pingcap#5150) close pingcap#5151 optimize ps v3 restore (pingcap#5163) ref pingcap#4914 Fix build failed (pingcap#5196) close pingcap#5195 feat: delta tree dispatching (pingcap#5199) close pingcap#5200 feat: introduce specialized API to write fixed length data rapidly (pingcap#5181) close pingcap#5183 Add gtest for Limit, TopN, Projection (pingcap#5187) (pingcap#5188) close pingcap#5187 add `MPPTask::handleError()` (pingcap#5202) ref pingcap#5095 Check result of starting grpc server (pingcap#5257) close pingcap#5255 feat: add optimized routines for aarch64 (pingcap#5231) close pingcap#5240 fix: aarch64-quick-fix (pingcap#5259) close pingcap#5260 Update client-c to support ipv6 (pingcap#5270) close pingcap#5247 upgrade prometheus-cpp to v1.0.1 (pingcap#5279) ref pingcap#2103, close pingcap#5278 Fix README type error (pingcap#5273) ref pingcap#5178 fix(cmake): make sure libc++ is utilized by tiflash-proxy (pingcap#5281) close pingcap#5282 fix the wrong order of execution summary for list based executors (pingcap#5242) close pingcap#5241 Schema: allow loading empty schema diff when the version grows up. (pingcap#5245) close pingcap#5244 Optimize apply speed under heavy write pressure (pingcap#4883) ref pingcap#4728 update proxy to raftstore-proxy-6.2 (pingcap#5287) ref pingcap#4982 Flush segment cache when doing the compaction (pingcap#5284) close pingcap#5179 metrics: Fix incorrect metrics for delta_merge tasks (pingcap#5061) close pingcap#5055 dep: upgrade jemalloc (pingcap#5197) close pingcap#5258 *: TiFlash pagectl/dttool use only-decryption mode (pingcap#5271) close pingcap#5122 suppresion false positive report from tsan (pingcap#5303) close pingcap#5088 Refine test framework code and tests (pingcap#5261) close pingcap#5262 feat: add logical cpu cores and memory into grafana (pingcap#5124) close pingcap#3821 Implement TimeToSec function push down (pingcap#5235) close pingcap#5116 feat: implement shiftRight function push down (pingcap#5156) close pingcap#5100 schema : make update to partition tables when 'set tiflash replica' (pingcap#5267) close pingcap#5266 Replace initializer_list with vector for planner test framework (pingcap#5307) close pingcap#5295 KVStore: decouple flush region and CompactLog with a new FFI fn_try_flush_data (pingcap#5283) ref pingcap#5170 refine error message in mpptask (pingcap#5304) ref pingcap#5095 Implement ReverseUTF8/Reverse function push down (pingcap#5233) close pingcap#5111 Optimize comparision for collation `UTF8_BIN` and `UTF8MB4_BIN` (pingcap#5299) ref pingcap#5294 feat : support set tiflash mode ddl action (pingcap#5256) ref pingcap#5252 Add non-blocking functions for MPMCQueue (pingcap#5311) close pingcap#5310 add random segment test for CI weekly (pingcap#5300) close pingcap#5301 *: tidy FunctionString.cpp (pingcap#5312) close pingcap#5313 ci: fix check-license github action (pingcap#5318) close pingcap#5317 update proxy to raftstore-proxy-6.2 (pingcap#5316) ref pingcap#4982 Change one `additional_input_at_end` to many streams in `ParallelInputsProcessor` (pingcap#5274) close pingcap#4856, close pingcap#5263 support fine grained shuffle for window function (pingcap#5048) close pingcap#5142 feat: pushdown get_format into TiFlash (pingcap#5269) close pingcap#5115 fix: format throw data truncated error (pingcap#5272) close pingcap#4891 Print content of columns for gtest (pingcap#5243) close pingcap#5203 *: also enable O3 for aarch64 (pingcap#5338) close pingcap#5342 Add debug image build target for CentOS7 (pingcap#5344) close pingcap#5343 *: mini refactor (pingcap#5326) close pingcap#4739 Refactor initialize of background pool (pingcap#5190) close pingcap#5189 delete copy/move ctor of MPMCQueue explicitly (pingcap#5328) close pingcap#5329 Introduce proxy_server and new-mock-engine-store (pingcap#5319) ref pingcap#5170 fix: incorrect uptime in grafana panel Signed-off-by: Lloyd-Pottiger <[email protected]>

close pingcap#5262

feat: refine skeleton code and tests

e1ca85d

Willendless changed the title ~~[WIP] feat: refine skeleton code and tests~~ [WIP] refine skeleton code and tests Jun 30, 2022

ti-chi-bot removed the do-not-merge/needs-linked-issue label Jun 30, 2022

Willendless changed the title ~~[WIP] refine skeleton code and tests~~ refine skeleton code and tests Jun 30, 2022

ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2022

Willendless changed the title ~~refine skeleton code and tests~~ Refine skeleton code and tests Jun 30, 2022

ti-chi-bot requested review from SeaRise and ywqzzy June 30, 2022 14:40

chore: update createColumns modifier

3feb925

Willendless added 2 commits June 30, 2022 19:09

feat: refine row set mismatch error output message

bcd476b

chore: update include header format

9e3681f

Willendless changed the title ~~Refine skeleton code and tests~~ Refine test framework code and tests Jul 1, 2022

SeaRise reviewed Jul 1, 2022

View reviewed changes

dbms/src/TestUtils/FunctionTestUtils.cpp Outdated Show resolved Hide resolved

dbms/src/Flash/tests/gtest_projection_executor.cpp Show resolved Hide resolved

Willendless added 2 commits July 1, 2022 15:31

chore: use fmtBuffer

1541902

chore: remove comment

aa38621

SeaRise approved these changes Jul 2, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 2, 2022

ywqzzy reviewed Jul 4, 2022

View reviewed changes

Willendless changed the title ~~Refine test framework code and tests~~ [DNM] Refine test framework code and tests Jul 4, 2022

SeaRise reviewed Jul 4, 2022

View reviewed changes

dbms/src/TestUtils/ExecutorTestUtils.cpp Outdated Show resolved Hide resolved

Willendless added 4 commits July 4, 2022 12:04

chore: format include headers and comment

0dae32c

chore: remove useless include header

6236212

chore: remove useless include header

0ea5eb8

chore: format

b57327e

Willendless changed the title ~~[DNM] Refine test framework code and tests~~ Refine test framework code and tests Jul 4, 2022

SeaRise requested a review from ywqzzy July 5, 2022 08:32

ywqzzy approved these changes Jul 6, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 6, 2022

Merge branch 'pingcap:master' into refine-executor-tests-framework

778275e

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2022

ti-chi-bot merged commit 57d001c into pingcap:master Jul 6, 2022

SeaRise mentioned this pull request Jul 14, 2022

Test aggregation functions #5364

Merged

12 tasks

Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tiflash that referenced this pull request Jul 19, 2022

Refine test framework code and tests (pingcap#5261)

716c2ac

close pingcap#5262

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refine test framework code and tests #5261

Refine test framework code and tests #5261

Willendless commented Jun 30, 2022 •

edited

Loading

ti-chi-bot commented Jun 30, 2022 •

edited

Loading

Willendless commented Jun 30, 2022

sre-bot commented Jun 30, 2022

Willendless commented Jun 30, 2022

ti-chi-bot commented Jun 30, 2022

Willendless commented Jun 30, 2022

sre-bot commented Jun 30, 2022

Willendless commented Jun 30, 2022

sre-bot commented Jun 30, 2022

Willendless commented Jul 1, 2022

sre-bot commented Jul 1, 2022

SeaRise left a comment

ywqzzy left a comment

ywqzzy Jul 4, 2022

Willendless Jul 4, 2022

Willendless commented Jul 4, 2022

sre-bot commented Jul 4, 2022

Willendless commented Jul 6, 2022

sre-bot commented Jul 6, 2022

SeaRise commented Jul 6, 2022

ti-chi-bot commented Jul 6, 2022

ti-chi-bot commented Jul 6, 2022

sre-bot commented Jul 6, 2022

Refine test framework code and tests #5261

Refine test framework code and tests #5261

Conversation

Willendless commented Jun 30, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Jun 30, 2022 • edited Loading

Willendless commented Jun 30, 2022

sre-bot commented Jun 30, 2022

Coverage for changed files

Coverage summary

Willendless commented Jun 30, 2022

ti-chi-bot commented Jun 30, 2022

Willendless commented Jun 30, 2022

sre-bot commented Jun 30, 2022

Coverage for changed files

Coverage summary

Willendless commented Jun 30, 2022

sre-bot commented Jun 30, 2022

Coverage for changed files

Coverage summary

Willendless commented Jul 1, 2022

sre-bot commented Jul 1, 2022

Coverage for changed files

Coverage summary

SeaRise left a comment

Choose a reason for hiding this comment

ywqzzy left a comment

Choose a reason for hiding this comment

ywqzzy Jul 4, 2022

Choose a reason for hiding this comment

Willendless Jul 4, 2022

Choose a reason for hiding this comment

Willendless commented Jul 4, 2022

sre-bot commented Jul 4, 2022

Coverage for changed files

Coverage summary

Willendless commented Jul 6, 2022

sre-bot commented Jul 6, 2022

Coverage for changed files

Coverage summary

SeaRise commented Jul 6, 2022

ti-chi-bot commented Jul 6, 2022

ti-chi-bot commented Jul 6, 2022

sre-bot commented Jul 6, 2022

Coverage for changed files

Coverage summary

Willendless commented Jun 30, 2022 •

edited

Loading

ti-chi-bot commented Jun 30, 2022 •

edited

Loading