Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KVStore: decouple flush region and CompactLog with a new FFI fn_try_flush_data #5283

Merged
merged 22 commits into from
Jul 7, 2022
Merged

KVStore: decouple flush region and CompactLog with a new FFI fn_try_flush_data #5283

merged 22 commits into from
Jul 7, 2022

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Jul 4, 2022 •
edited
Loading

Signed-off-by: CalvinNeo [email protected]

What problem does this PR solve?

Issue Number: ref #5170

Problem Summary:

Currently, when exec CompactLog, we need to firstly try flush region. If this lead to a failure, we will return None, so Proxy will perform a rollback, which is not neat.

However, we decide to move the flush region prior to executing CompactLog. When we prepare to exec CompactLog on proxy side, we should call fn_try_flush_data for a flush if possible, and abort further execution when it returns False.

Meanwhile, we have another FFI fn_need_flush_data which returns true if TiFlash suggest a flush. However, keep in mind that fn_try_flush_data may not be True, even if fn_need_flush_data returns True.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo
initial
88fa980 
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hehechen
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2022
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
Copy link
Member Author

CalvinNeo commented Jul 4, 2022 •
edited
Loading

/cc @lidezhu @JaySon-Huang @hehechen

@CalvinNeo CalvinNeo changed the title KVStore: decouple flush region and CompactLog with FFI fn_can_flush_data [DNM]KVStore: decouple flush region and CompactLog with FFI fn_can_flush_data Jul 4, 2022
@CalvinNeo
Copy link
Member Author

Please DNM until raftstore-proxy-6.2 is merged into TiFlash's master.

@CalvinNeo
fix format
06d016d 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo CalvinNeo mentioned this pull request Jul 4, 2022
Closed
@CalvinNeo CalvinNeo changed the title [DNM]KVStore: decouple flush region and CompactLog with FFI fn_can_flush_data KVStore: decouple flush region and CompactLog with FFI fn_can_flush_data Jul 4, 2022
@SchrodingerZhu
Copy link
Contributor

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2022
CalvinNeo added 5 commits July 4, 2022 13:22
@CalvinNeo
fix
2329252 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
fix
e1ef97c 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Merge remote-tracking branch 'upstream/master' into add-can-flush-data
65d8501
@CalvinNeo
f
cec40ac 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
f
4176d4e 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
fix tests
d7e191b 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/rebuild

@CalvinNeo
comment
5242ff2 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo CalvinNeo changed the title KVStore: decouple flush region and CompactLog with FFI fn_can_flush_data KVStore: decouple flush region and CompactLog with a new FFI fn_can_flush_data Jul 5, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2022
@CalvinNeo
f
0695184 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
f
5b22970 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 6, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
KVStore.cpp                       410                80    80.49%          43                 3    93.02%         691                87    87.41%         220                79    64.09%
KVStore.h                           5                 3    40.00%           5                 3    40.00%           5                 3    40.00%           0                 0         -
ProxyFFI.cpp                      180               116    35.56%          43                26    39.53%         370               259    30.00%          68                31    54.41%
ProxyFFI.h                          3                 2    33.33%           3                 2    33.33%          27                26     3.70%           0                 0         -
tests/gtest_kvstore.cpp          3707               724    80.47%          26                 2    92.31%        1263                30    97.62%        1102               583    47.10%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            4305               925    78.51%         120                36    70.00%        2356               405    82.81%        1390               693    50.14%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18415      9644             47.63%    207268  96595        53.40%

full coverage report (for internal network access only)

@CalvinNeo
f
4b9c75c 
Signed-off-by: CalvinNeo <[email protected]>
CalvinNeo added 2 commits July 7, 2022 11:16
@CalvinNeo
f
838846d 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
f
ecb96ec 
Signed-off-by: CalvinNeo <[email protected]>
lidezhu
lidezhu approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 7, 2022
@CalvinNeo CalvinNeo changed the title KVStore: decouple flush region and CompactLog with a new FFI fn_can_flush_data KVStore: decouple flush region and CompactLog with a new FFI fn_try_flush_data Jul 7, 2022
@CalvinNeo
Copy link
Member Author

/run-all-tests

@CalvinNeo
f
b574505 
Signed-off-by: CalvinNeo <[email protected]>
@CalvinNeo
Copy link
Member Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 7, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
KVStore.cpp                       411                81    80.29%          44                 3    93.18%         696                87    87.50%         220                81    63.18%
KVStore.h                           5                 3    40.00%           5                 3    40.00%           5                 3    40.00%           0                 0         -
ProxyFFI.cpp                      180               116    35.56%          43                26    39.53%         370               259    30.00%          68                31    54.41%
ProxyFFI.h                          3                 2    33.33%           3                 2    33.33%          27                26     3.70%           0                 0         -
tests/gtest_kvstore.cpp          3686               721    80.44%          26                 2    92.31%        1253                30    97.61%        1096               580    47.08%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            4285               923    78.46%         121                36    70.25%        2351               405    82.77%        1384               692    50.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18416      9644             47.63%    207263  96587        53.40%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 7, 2022
@CalvinNeo
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b574505

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 7, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 7, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
KVStore.cpp                       411                81    80.29%          44                 3    93.18%         696                87    87.50%         220                81    63.18%
KVStore.h                           5                 3    40.00%           5                 3    40.00%           5                 3    40.00%           0                 0         -
ProxyFFI.cpp                      180               116    35.56%          43                26    39.53%         370               259    30.00%          68                31    54.41%
ProxyFFI.h                          3                 2    33.33%           3                 2    33.33%          27                26     3.70%           0                 0         -
tests/gtest_kvstore.cpp          3686               721    80.44%          26                 2    92.31%        1253                30    97.61%        1096               580    47.08%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            4285               923    78.46%         121                36    70.25%        2351               405    82.77%        1384               692    50.00%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18416      9644             47.63%    207263  96602        53.39%

full coverage report (for internal network access only)

@CalvinNeo
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2022
@ti-chi-bot
Copy link
Member

@CalvinNeo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 7, 2022

Coverage for changed files

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
KVStore.cpp                       411                80    80.54%          44                 3    93.18%         696                87    87.50%         220                79    64.09%
KVStore.h                           5                 3    40.00%           5                 3    40.00%           5                 3    40.00%           0                 0         -
ProxyFFI.cpp                      180               116    35.56%          43                26    39.53%         370               259    30.00%          68                31    54.41%
ProxyFFI.h                          3                 2    33.33%           3                 2    33.33%          27                26     3.70%           0                 0         -
tests/gtest_kvstore.cpp          3686               721    80.44%          26                 2    92.31%        1253                30    97.61%        1096               580    47.08%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            4285               922    78.48%         121                36    70.25%        2351               405    82.77%        1384               690    50.14%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18435      9620             47.82%    207613  96548        53.50%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 0aec04a into pingcap:master Jul 7, 2022
Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tiflash that referenced this pull request Jul 12, 2022
@hongyunyan @Lloyd-Pottiger
Enhancement: Add how to run integration tests and microbenchmark test…
4e4f3b7 
…s in README (pingcap#5182)

close pingcap#5172, ref pingcap#5178

Enhancement: add a integrated test on DDL module (pingcap#5130)

ref pingcap#5129

Revert "Revise default background threads size" (pingcap#5176)

close pingcap#5177

chore: remove extra dyn cast (pingcap#5186)

close pingcap#5185

Add MPPReceiverSet, which includes ExchangeReceiver and CoprocessorReader (pingcap#5175)

ref pingcap#5095

DDL: Use Column Name Instead of Offset to Find the common handle cluster index (pingcap#5166)

close pingcap#5154

Add random failpoint in critical paths (pingcap#4876)

close pingcap#4807

Segment test framework (pingcap#5150)

close pingcap#5151

optimize ps v3 restore (pingcap#5163)

ref pingcap#4914

Fix build failed (pingcap#5196)

close pingcap#5195

feat: delta tree dispatching (pingcap#5199)

close pingcap#5200

feat: introduce specialized API to write fixed length data rapidly (pingcap#5181)

close pingcap#5183

Add gtest for Limit, TopN, Projection (pingcap#5187) (pingcap#5188)

close pingcap#5187

add `MPPTask::handleError()` (pingcap#5202)

ref pingcap#5095

Check result of starting grpc server (pingcap#5257)

close pingcap#5255

feat: add optimized routines for aarch64 (pingcap#5231)

close pingcap#5240

fix: aarch64-quick-fix (pingcap#5259)

close pingcap#5260

Update client-c to support ipv6 (pingcap#5270)

close pingcap#5247

upgrade prometheus-cpp to v1.0.1 (pingcap#5279)

ref pingcap#2103, close pingcap#5278

Fix README type error (pingcap#5273)

ref pingcap#5178

fix(cmake): make sure libc++ is utilized by tiflash-proxy (pingcap#5281)

close pingcap#5282

fix the wrong order of execution summary for list based executors (pingcap#5242)

close pingcap#5241

Schema: allow loading empty schema diff when the version grows up. (pingcap#5245)

close pingcap#5244

Optimize apply speed under heavy write pressure (pingcap#4883)

ref pingcap#4728

update proxy to raftstore-proxy-6.2 (pingcap#5287)

ref pingcap#4982

Flush segment cache when doing the compaction (pingcap#5284)

close pingcap#5179

metrics: Fix incorrect metrics for delta_merge tasks (pingcap#5061)

close pingcap#5055

dep: upgrade jemalloc (pingcap#5197)

close pingcap#5258

*: TiFlash pagectl/dttool use only-decryption mode (pingcap#5271)

close pingcap#5122

suppresion false positive report from tsan (pingcap#5303)

close pingcap#5088

Refine test framework code and tests (pingcap#5261)

close pingcap#5262

feat: add logical cpu cores and memory into grafana (pingcap#5124)

close pingcap#3821

Implement TimeToSec function push down (pingcap#5235)

close pingcap#5116

feat: implement shiftRight function push down (pingcap#5156)

close pingcap#5100

schema : make update to partition tables when 'set tiflash replica' (pingcap#5267)

close pingcap#5266

Replace initializer_list with vector for planner test framework (pingcap#5307)

close pingcap#5295

KVStore: decouple flush region and CompactLog with a new FFI fn_try_flush_data (pingcap#5283)

ref pingcap#5170

refine error message in mpptask (pingcap#5304)

ref pingcap#5095

Implement ReverseUTF8/Reverse function push down (pingcap#5233)

close pingcap#5111

Optimize comparision for collation `UTF8_BIN` and `UTF8MB4_BIN` (pingcap#5299)

ref pingcap#5294

feat : support set tiflash mode ddl action (pingcap#5256)

ref pingcap#5252

Add non-blocking functions for MPMCQueue (pingcap#5311)

close pingcap#5310

add random segment test for CI weekly (pingcap#5300)

close pingcap#5301

*: tidy FunctionString.cpp (pingcap#5312)

close pingcap#5313

ci: fix check-license github action (pingcap#5318)

close pingcap#5317

update proxy to raftstore-proxy-6.2 (pingcap#5316)

ref pingcap#4982

Change one `additional_input_at_end` to many streams in `ParallelInputsProcessor`  (pingcap#5274)

close pingcap#4856, close pingcap#5263

support fine grained shuffle for window function (pingcap#5048)

close pingcap#5142

feat: pushdown get_format into TiFlash (pingcap#5269)

close pingcap#5115

fix: format throw data truncated error (pingcap#5272)

close pingcap#4891

Print content of columns for gtest (pingcap#5243)

close pingcap#5203

*: also enable O3 for aarch64 (pingcap#5338)

close pingcap#5342

Add debug image build target for CentOS7 (pingcap#5344)

close pingcap#5343

*: mini refactor (pingcap#5326)

close pingcap#4739

Refactor initialize of background pool (pingcap#5190)

close pingcap#5189

delete copy/move ctor of MPMCQueue explicitly (pingcap#5328)

close pingcap#5329

Introduce proxy_server and new-mock-engine-store (pingcap#5319)

ref pingcap#5170

fix: incorrect uptime in grafana panel

Signed-off-by: Lloyd-Pottiger <[email protected]>
Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tiflash that referenced this pull request Jul 19, 2022
@CalvinNeo @Lloyd-Pottiger
KVStore: decouple flush region and CompactLog with a new FFI fn_try_f…
c191d0a 
…lush_data (pingcap#5283)

ref pingcap#5170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidezhu lidezhu lidezhu approved these changes

@hehechen hehechen hehechen approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CalvinNeo @ti-chi-bot @SchrodingerZhu @sre-bot @hehechen @lidezhu