upgrade prometheus-cpp to v1.0.1

[YangKeao]

Signed-off-by: YangKeao [email protected]

What problem does this PR solve?

Issue Number: close #5278 #2103

Problem Summary:

The prometheus-cpp in tiflash is out of date, and will cause compile-error in new version of libstdc++

What is changed and how it works?

Upgrade the prometheus-cpp to v1.0.1. Modify the cmake files according to the repo.

Check List

Tests

• No code

Release Note

none

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• SchrodingerZhu
• fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[YangKeao]

/cc @SchrodingerZhu

[SchrodingerZhu]

may I ask which symbol is utilized here?

[SchrodingerZhu]

libatomic is a sublib of libgcc series to dispatch atomic operations. clang however should generate instrinction directly for most atomic operations as long as the hardware feature flags are set. We do not set -mcx16 yet for tiflash, but that is something generally available for x86-64-v2 target, which is within the assumption of tiflash. So, if that is the problem, I would prefer adding -mcx16 on x86-64 platform instead.

[SchrodingerZhu]

if(CMAKE_CXX_COMPILER_ID MATCHES "Clang|GNU")
  # First check if atomics work without the library.
  check_working_cxx_atomics(HAVE_CXX_ATOMICS_WITHOUT_LIB)
  # If not, check if the library exists, and atomics work with it.
  if(NOT HAVE_CXX_ATOMICS_WITHOUT_LIB)
    check_library_exists(atomic __atomic_load_8 "" HAVE_CXX_LIBATOMIC)
    if(HAVE_CXX_LIBATOMIC)
      list(APPEND CMAKE_REQUIRED_LIBRARIES "atomic")
      check_working_cxx_atomics(HAVE_CXX_ATOMICS_WITH_LIB)
      if(NOT HAVE_CXX_ATOMICS_WITH_LIB)
        message(FATAL_ERROR "Host compiler must support 64-bit std::atomic!")
      endif()
    else()
      message(FATAL_ERROR "Host compiler appears to require libatomic for 64-bit operations, but cannot find it.")
    endif()
  endif()
endif()

checking into the implementation, this seems to be a compatible flag for special architectures without even 8-byte atomic load. I think we can skip the check here?

[YangKeao]

I just (carelessly) copy these CMakeLists from the upstream. Nothing will set this variable so it's fine to remove this condition.

The upstream has a another CMakeList, which checked whether the compiler can compile without libatomic. If not, the HAVE_CXX_LIBATOMIC will be set. See jupp0r/prometheus-cpp@d0e1056

I've removed these lines in the latest commit

[SchrodingerZhu]

/run-all-tests

[SchrodingerZhu]

/run-release-build

[SchrodingerZhu]

/run-build-release

[sre-bot]

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18405      9638             47.63%    207054  96457        53.41%

full coverage report (for internal network access only)

[sre-bot]

download tiflash binary(linux amd64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tiflash/aedda8ad472b1c72073099119c77b6b921bbbe93/centos7/tiflash-linux-amd64.tar.gz

[SchrodingerZhu]

/merge

[ti-chi-bot]

@SchrodingerZhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: aedda8a

[SchrodingerZhu]

/run-all-tests

[SchrodingerZhu]

/build

[SchrodingerZhu]

/run-integration-test

[sre-bot]

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18405      9638             47.63%    207054  96423        53.43%

full coverage report (for internal network access only)

[YangKeao]

🍻