Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement TimeToSec function push down #5235

Merged
merged 6 commits into from
Jul 7, 2022
Merged

Implement TimeToSec function push down #5235

merged 6 commits into from
Jul 7, 2022

Conversation

hey-kong
Copy link
Contributor

@hey-kong hey-kong commented Jun 26, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5116

Problem Summary:
Implement TimeToSec function push down.

What is changed and how it works?

Related pingcap/tidb#35739

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support function time_to_sec pushdown to tiflash.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • zanmato1984

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 26, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jun 26, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Member

Welcome @hey-kong!

It looks like this is your first PR to pingcap/tiflash 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/tiflash. 😃

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 26, 2022
@Lloyd-Pottiger
Copy link
Contributor

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 26, 2022

Coverage for changed files

Filename                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyDuration.cpp                                18                13    27.78%           7                 2    71.43%          42                27    35.71%           8                 8     0.00%
Common/MyDuration.h                                  33                 6    81.82%           4                 0   100.00%          22                 6    72.73%          24                10    58.33%
Flash/Coprocessor/DAGUtils.cpp                      347               155    55.33%          45                15    66.67%         638               294    53.92%         412               197    52.18%
Functions/FunctionsDuration.cpp                      46                 8    82.61%          12                 0   100.00%         133                50    62.41%          24                 9    62.50%
Functions/FunctionsDuration.h                        13                 3    76.92%          13                 3    76.92%          13                 3    76.92%           0                 0         -
Functions/tests/gtest_duration_pushdown.cpp         493               161    67.34%           3                 0   100.00%         194                 4    97.94%         116                57    50.86%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                               950               346    63.58%          84                20    76.19%        1042               384    63.15%         584               281    51.88%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18396      9659             47.49%    206864  96759        53.23%

full coverage report (for internal network access only)

@hey-kong hey-kong mentioned this pull request Jun 26, 2022
Merged
12 tasks
ywqzzy
ywqzzy reviewed Jun 28, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, nice job.

dbms/src/Functions/tests/gtest_duration_pushdown.cpp Outdated Show resolved Hide resolved
dbms/src/Functions/FunctionsDuration.cpp Outdated Show resolved Hide resolved
@zanmato1984
Copy link
Contributor

Thanks for your contribution. We really appreciate that.

@hey-kong
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 28, 2022

Coverage for changed files

Filename                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyDuration.cpp                                18                13    27.78%           7                 2    71.43%          42                27    35.71%           8                 8     0.00%
Common/MyDuration.h                                  33                 6    81.82%           4                 0   100.00%          22                 6    72.73%          24                10    58.33%
Flash/Coprocessor/DAGUtils.cpp                      347               155    55.33%          45                15    66.67%         638               294    53.92%         412               197    52.18%
Functions/FunctionsDuration.cpp                      46                 8    82.61%          12                 0   100.00%         133                50    62.41%          24                 9    62.50%
Functions/FunctionsDuration.h                        13                 3    76.92%          13                 3    76.92%          13                 3    76.92%           0                 0         -
Functions/tests/gtest_duration_pushdown.cpp         493               161    67.34%           3                 0   100.00%         194                 4    97.94%         116                57    50.86%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                               950               346    63.58%          84                20    76.19%        1042               384    63.15%         584               281    51.88%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18396      9658             47.50%    206864  96769        53.22%

full coverage report (for internal network access only)

@hey-kong
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 28, 2022

Coverage for changed files

Filename                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyDuration.cpp                                17                13    23.53%           6                 2    66.67%          39                27    30.77%           8                 8     0.00%
Flash/Coprocessor/DAGUtils.cpp                      347               155    55.33%          45                15    66.67%         638               294    53.92%         412               197    52.18%
Functions/FunctionsDuration.cpp                      46                 8    82.61%          12                 0   100.00%         133                50    62.41%          24                 9    62.50%
Functions/FunctionsDuration.h                        13                 3    76.92%          13                 3    76.92%          13                 3    76.92%           0                 0         -
Functions/tests/gtest_duration_pushdown.cpp         493               161    67.34%           3                 0   100.00%         194                 4    97.94%         116                57    50.86%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                               916               340    62.88%          79                20    74.68%        1017               378    62.83%         560               271    51.61%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18395      9659             47.49%    206861  96766        53.22%

full coverage report (for internal network access only)

zanmato1984
zanmato1984 approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2022
@zanmato1984
Copy link
Contributor

@hey-kong Would you please link the corresponding tidb side pr in the description of this pr?

@hey-kong
Copy link
Contributor Author

@hey-kong Would you please link the corresponding tidb side pr in the description of this pr?

Done.

@zanmato1984
Copy link
Contributor

@hey-kong Would you please link the corresponding tidb side pr in the description of this pr?

Done.

Thanks. I'm looking at it.

@Willendless Willendless mentioned this pull request Jun 29, 2022
Open
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 4, 2022
@zanmato1984
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@zanmato1984: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b6f70a7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 7, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jul 7, 2022

Coverage for changed files

Filename                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyDuration.cpp                                17                13    23.53%           6                 2    66.67%          39                27    30.77%           8                 8     0.00%
Flash/Coprocessor/DAGUtils.cpp                      347               155    55.33%          45                15    66.67%         638               294    53.92%         412               197    52.18%
Functions/FunctionsDuration.cpp                      46                 8    82.61%          12                 0   100.00%         133                50    62.41%          24                 9    62.50%
Functions/FunctionsDuration.h                        13                 3    76.92%          13                 3    76.92%          13                 3    76.92%           0                 0         -
Functions/tests/gtest_duration_pushdown.cpp         493               161    67.34%           3                 0   100.00%         194                 4    97.94%         116                57    50.86%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                               916               340    62.88%          79                20    74.68%        1017               378    62.83%         560               271    51.61%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18431      9625             47.78%    207443  96560        53.45%

full coverage report (for internal network access only)

@ti-chi-bot
Copy link
Member

@hey-kong: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 7, 2022

Coverage for changed files

Filename                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/MyDuration.cpp                                17                13    23.53%           6                 2    66.67%          39                27    30.77%           8                 8     0.00%
Flash/Coprocessor/DAGUtils.cpp                      347               155    55.33%          45                15    66.67%         638               294    53.92%         412               197    52.18%
Functions/FunctionsDuration.cpp                      46                 8    82.61%          12                 0   100.00%         133                50    62.41%          24                 9    62.50%
Functions/FunctionsDuration.h                        13                 3    76.92%          13                 3    76.92%          13                 3    76.92%           0                 0         -
Functions/tests/gtest_duration_pushdown.cpp         493               161    67.34%           3                 0   100.00%         194                 4    97.94%         116                57    50.86%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                               916               340    62.88%          79                20    74.68%        1017               378    62.83%         560               271    51.61%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18431      9625             47.78%    207443  96507        53.48%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit d9b7086 into pingcap:master Jul 7, 2022
@hey-kong hey-kong deleted the dev branch July 11, 2022 02:31
Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tiflash that referenced this pull request Jul 12, 2022
@hongyunyan @Lloyd-Pottiger
Enhancement: Add how to run integration tests and microbenchmark test…
4e4f3b7 
…s in README (pingcap#5182)

close pingcap#5172, ref pingcap#5178

Enhancement: add a integrated test on DDL module (pingcap#5130)

ref pingcap#5129

Revert "Revise default background threads size" (pingcap#5176)

close pingcap#5177

chore: remove extra dyn cast (pingcap#5186)

close pingcap#5185

Add MPPReceiverSet, which includes ExchangeReceiver and CoprocessorReader (pingcap#5175)

ref pingcap#5095

DDL: Use Column Name Instead of Offset to Find the common handle cluster index (pingcap#5166)

close pingcap#5154

Add random failpoint in critical paths (pingcap#4876)

close pingcap#4807

Segment test framework (pingcap#5150)

close pingcap#5151

optimize ps v3 restore (pingcap#5163)

ref pingcap#4914

Fix build failed (pingcap#5196)

close pingcap#5195

feat: delta tree dispatching (pingcap#5199)

close pingcap#5200

feat: introduce specialized API to write fixed length data rapidly (pingcap#5181)

close pingcap#5183

Add gtest for Limit, TopN, Projection (pingcap#5187) (pingcap#5188)

close pingcap#5187

add `MPPTask::handleError()` (pingcap#5202)

ref pingcap#5095

Check result of starting grpc server (pingcap#5257)

close pingcap#5255

feat: add optimized routines for aarch64 (pingcap#5231)

close pingcap#5240

fix: aarch64-quick-fix (pingcap#5259)

close pingcap#5260

Update client-c to support ipv6 (pingcap#5270)

close pingcap#5247

upgrade prometheus-cpp to v1.0.1 (pingcap#5279)

ref pingcap#2103, close pingcap#5278

Fix README type error (pingcap#5273)

ref pingcap#5178

fix(cmake): make sure libc++ is utilized by tiflash-proxy (pingcap#5281)

close pingcap#5282

fix the wrong order of execution summary for list based executors (pingcap#5242)

close pingcap#5241

Schema: allow loading empty schema diff when the version grows up. (pingcap#5245)

close pingcap#5244

Optimize apply speed under heavy write pressure (pingcap#4883)

ref pingcap#4728

update proxy to raftstore-proxy-6.2 (pingcap#5287)

ref pingcap#4982

Flush segment cache when doing the compaction (pingcap#5284)

close pingcap#5179

metrics: Fix incorrect metrics for delta_merge tasks (pingcap#5061)

close pingcap#5055

dep: upgrade jemalloc (pingcap#5197)

close pingcap#5258

*: TiFlash pagectl/dttool use only-decryption mode (pingcap#5271)

close pingcap#5122

suppresion false positive report from tsan (pingcap#5303)

close pingcap#5088

Refine test framework code and tests (pingcap#5261)

close pingcap#5262

feat: add logical cpu cores and memory into grafana (pingcap#5124)

close pingcap#3821

Implement TimeToSec function push down (pingcap#5235)

close pingcap#5116

feat: implement shiftRight function push down (pingcap#5156)

close pingcap#5100

schema : make update to partition tables when 'set tiflash replica' (pingcap#5267)

close pingcap#5266

Replace initializer_list with vector for planner test framework (pingcap#5307)

close pingcap#5295

KVStore: decouple flush region and CompactLog with a new FFI fn_try_flush_data (pingcap#5283)

ref pingcap#5170

refine error message in mpptask (pingcap#5304)

ref pingcap#5095

Implement ReverseUTF8/Reverse function push down (pingcap#5233)

close pingcap#5111

Optimize comparision for collation `UTF8_BIN` and `UTF8MB4_BIN` (pingcap#5299)

ref pingcap#5294

feat : support set tiflash mode ddl action (pingcap#5256)

ref pingcap#5252

Add non-blocking functions for MPMCQueue (pingcap#5311)

close pingcap#5310

add random segment test for CI weekly (pingcap#5300)

close pingcap#5301

*: tidy FunctionString.cpp (pingcap#5312)

close pingcap#5313

ci: fix check-license github action (pingcap#5318)

close pingcap#5317

update proxy to raftstore-proxy-6.2 (pingcap#5316)

ref pingcap#4982

Change one `additional_input_at_end` to many streams in `ParallelInputsProcessor`  (pingcap#5274)

close pingcap#4856, close pingcap#5263

support fine grained shuffle for window function (pingcap#5048)

close pingcap#5142

feat: pushdown get_format into TiFlash (pingcap#5269)

close pingcap#5115

fix: format throw data truncated error (pingcap#5272)

close pingcap#4891

Print content of columns for gtest (pingcap#5243)

close pingcap#5203

*: also enable O3 for aarch64 (pingcap#5338)

close pingcap#5342

Add debug image build target for CentOS7 (pingcap#5344)

close pingcap#5343

*: mini refactor (pingcap#5326)

close pingcap#4739

Refactor initialize of background pool (pingcap#5190)

close pingcap#5189

delete copy/move ctor of MPMCQueue explicitly (pingcap#5328)

close pingcap#5329

Introduce proxy_server and new-mock-engine-store (pingcap#5319)

ref pingcap#5170

fix: incorrect uptime in grafana panel

Signed-off-by: Lloyd-Pottiger <[email protected]>
Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tiflash that referenced this pull request Jul 19, 2022
@hey-kong @Lloyd-Pottiger
Implement TimeToSec function push down (pingcap#5235)
48558ba 
close pingcap#5116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bestwoody bestwoody bestwoody left review comments

@ywqzzy ywqzzy ywqzzy left review comments

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@guo-shaoge guo-shaoge guo-shaoge approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement TimeToSec function push down
8 participants
@hey-kong @ti-chi-bot @sre-bot @Lloyd-Pottiger @zanmato1984 @guo-shaoge @ywqzzy @bestwoody