What (if anything) is blocking an official final Pester 4.0?

[Jaykul]

I'm sure my team isn't the only one that's uncomfortable moving to 4 on the build server while it's RC... and I really want the mocking scope changes! 😉

If there's anything that really needs to be fixed before we call 4 "done," can we make a list?
Maybe use the "Projects" tab, or list them in a meta issue the way the PowerShell team was doing?

[alx9r]

If there are blocking issues that are identified, I can probably allocate some of my time to resolving them.

[it-praktyk]

From my point of view before release 4.0.x RTM should be

Issues

• Update README.MD to v4 #687 - completed
• Should there be dedicated release notes? #811
• Unexpected output when passing hashtable to Invoke-Pester #699 - completed - related PR Fix header when passing in hashtables #816 Fix Write-PesterStart to allow hashtables in $Path #799
• [Pester 4.02] Bug in output where multiple Paths are passed in to -Scripts at Invoke-Pester #710 - completed - related PR Fix header when passing in hashtables #816 Fix Write-PesterStart to allow hashtables in $Path #799
• [Pester 4.0.2] Gherkin scenario counts are broken #714 - reviewed
• [Pester 4.0.2] Import-LocalizedData not in $script:SafeCommands  #712 - at least triaged
• Context not in nunitXml export #733 - at least triaged ( seems to be working fine, waiting for input from OP)
• Get-WmiObject is not included in the SafeCommands table #768 - at least triaged
• -Tag, -ExcludeTag, and -TestName parameters are executing all .Tests.ps1 files #770 - at least triaged, if only documentation need to be updated than completed (works as expected)
• Assert-VerifiableMocks silently does not report anything if 'Verifiable' is spelled wrong on one mock #781 - completed - related PR Fix Assert-VerifiableMocks silently does not report anything if 'Verifiable' is spelled wrong on one mock #786
• [Pester 4.0.3] Call depth overflow on $xmlObject | Should be $xmlObject #785 - at least triaged
• Pester 4.0 undoes PR #426 #815

Updates

• [Pester 4.0.3] Call depth overflow on $xmlObject | Should be $xmlObject #785 added based on @alx9r request (2017-06-29)

Pull requests

• Rename indentation test #763 - merged (trivial)
• Make Add-AssertionOperator a public function #765 - reviewed, merged
• Cleaning of code - PSScriptAnalyzer rules #766
  • reviewed, merged - at least ebfbdad
  • @Jaykul answer for Cleaning of code - PSScriptAnalyzer rules #766 (comment) needed - related pull request Remove unused variables #801
• add tests and use .get_Keys() instead of .Keys [V3Maintenance] #777 - reviewed, merged
• Information about Set-TestInconclusive added to the It function #778 - merged (trivial)
• Renamed common function name to prevent conflict with local scope #779 - reviewed, merged ( cannot replicate )
• Add support for JaCoCo XML code coverage reports. #782 - reviewed, merged
• Fix Assert-VerifiableMocks silently does not report anything if 'Verifiable' is spelled wrong on one mock #786 - reviewed, merged
• Remove unused variables #801 - merged (trivial)
• Fix header when passing in hashtables #816 - reviewed, merged

V4 milestone updates

• 2017-07-25
  • PR Cleaning of code - PSScriptAnalyzer rules #766 - split, partially completed
  • PR Remove unused variables #801 added
• 2017-07-31
  • PR Cleaning of code - PSScriptAnalyzer rules #766 - completed
  • ISSSUE Get-WmiObject is not included in the SafeCommands table #768 - only V3Maintenance affected
• 2017-08-12
  • PR Renamed common function name to prevent conflict with local scope #779 cannot replicate the issue mentioned in the PR
  • PR Fix Write-PesterStart to allow hashtables in $Path #799 removed, and replaced by in Fix header when passing in hashtables #816
  • Add Pester 4.0 undoes PR #426 #815
  • reviewed everything else
• 2017-08-16
  • updated checkboxes
  • added Should there be dedicated release notes? #811

[dlwyatt]

I'll be off work for a few days next week, which tends to be my best time for knocking out Pester stuff. Will review these asap.

[alx9r]

@it-praktyk I think #785 should be investigated and understood for 4.0. It seems unlikely that whatever is causing the call depth overflow affects only XML objects.

[mrboring]

I'm confused! I hope you can help. The releases tab shows that 3.4.3 was the "Latest release". However, PSGallery shows relases after that, but does not state that they are beta/rc. Also, if I do update-module I get 4.0.3.

What is the official release?
If it's 3.4.3, why do I get 4.0.3 from PSGallery/update-module?
Should I not only get the latest official release from PSGallery/update-module?
Can I assume that, as 4.0.3 is an rc, I'm safe using it?

Thanks.

[nohwnd]

PsGallery does not support beta releases, so the 4.0.3 is really a full release, even though we still consider it RC. But it has been in the wild for so long that I am not sure if that distinction still has any meaning.

[alx9r]

@it-praktyk I think #794 should be considered for 4.0 RC as well.

[mrboring]

@nohwnd Thanks for your response.

[nohwnd]

Thanks for putting the list together. I've made all of the issues and tickets part of milestone v4 so we can track them more easily. We can still keep this list up to date, but it's easier if it's done automatically in the milestone.

If there are more things popping up please add them to the bottom of their respective list so it's easier to keep the milestone in sync with this list.

[nohwnd]

@Jaykul "and I really want the mocking scope changes!" Did not see anything related to this in the listed issues, what exactly are you referring to? :)

[Jaykul]

@nohwnd That's the stuff that Dave did with regard to making mocks be scoped to Describe (and Context). Not something that needs to be done, just one of the main things I want to start using, that are in 4.0 😀

[nohwnd]

So only readme and release notes are missing from this milestone, I am building 4.0.6-rc so people can try it and report back before we finish the documentation, and finally release :)

[nohwnd]

@dlwyatt I think #826 has a good point, It should fail when no test cases are provided, and this is probably the best time to change the behavior. Do you agree to put it in v4?

Disregard that, we need to first agree what the correct behavior is, removing it from this milestone.

[nohwnd]

I set the v4 milestone to be due this Friday. I will be on work trip the whole week, which usually means a lot of time for coding during the travel and evenings. I hope I will merge all the PRs, write all the help and fix all issues.

[it-praktyk]

Please review issues labeled as need to be triaged too. Thank you.

[nohwnd]

Nothing anymore 🍾 🎈 🍰