Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pester 4.0 undoes PR #426 #815

Closed
alx9r opened this issue Aug 12, 2017 · 2 comments
Closed

Pester 4.0 undoes PR #426 #815

alx9r opened this issue Aug 12, 2017 · 2 comments
Assignees
Milestone

Comments

@alx9r
Copy link
Member

alx9r commented Aug 12, 2017

Pester 4.0 undoes PR #426. Invoking @nohwnd's test outputs only one line of the stack trace:

image

This diff shows that somewhere between 3.4.3 and c3d84de (HEAD of today's master) the changes from PR #426 (including the tests) were removed.

@nohwnd nohwnd added this to the V4 milestone Aug 12, 2017
@nohwnd
Copy link
Member

nohwnd commented Aug 12, 2017

gotta have a closer look, there was quite a few changes when forward merging 3 to 4, so possibly your changes got lost. Sorry about that.

@nohwnd
Copy link
Member

nohwnd commented Aug 12, 2017

So I put the code back in, it was omitted when there was confusion about what output to use. There are some errors, still, but the above tests looks exactly as in the #426 thread, so I am on a good path.

nohwnd added a commit that referenced this issue Aug 12, 2017
Add the improved error formatting back in, one of the tests is commented out becuase it behaves weirdly, because Should changed.

Fix #815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants