Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pester 4.0.2] Import-LocalizedData not in $script:SafeCommands #712

Closed
it-praktyk opened this issue Jan 27, 2017 · 3 comments
Closed

[Pester 4.0.2] Import-LocalizedData not in $script:SafeCommands #712

it-praktyk opened this issue Jan 27, 2017 · 3 comments
Assignees
@nohwnd
Milestone
V4.0

Comments

@it-praktyk
Copy link
Contributor

it-praktyk commented Jan 27, 2017 •
edited
Loading

I'm not sure if is it issue but the command Import-LocalizedData are not added to $script:SafeCommands and is invoked directly.

I see in a code that all (?) ordinary commands are called by

$script:SafeCommands['Get-WmiObject']

except Import-LocalizedData what is used in

Mentioned lines are also part of the pull request #711

2017-03-31 - the links updated due to move V4 to the master branch and changed numbers of affected lines due to a code change.
This was referenced Mar 31, 2017
Closed
Closed
@it-praktyk it-praktyk mentioned this issue Jun 29, 2017
Closed
@nohwnd nohwnd added this to the V4 milestone Jul 25, 2017
@nohwnd nohwnd mentioned this issue Aug 12, 2017
Merged
@nohwnd nohwnd self-assigned this Aug 12, 2017
@it-praktyk
Copy link
Contributor Author

Thank you @nohwnd.

@nohwnd nohwnd reopened this Aug 12, 2017
@nohwnd
Copy link
Member

nohwnd commented Aug 12, 2017

@it-praktyk no need to close this manually before the PR is merged. :)

nohwnd added a commit that referenced this issue Aug 12, 2017
@nohwnd
Add Import-LocalizedData to safe commands (#817)
5b7a9d0 
* Add one space in front of -Module to make new entry fit in

* Add Import-LocalizedData to safe commands and replace usages

Fix  #712
@it-praktyk
Copy link
Contributor Author

I didn't realize that it wasn't merged yet. Next time I'll try don't do things in my nap time ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nohwnd nohwnd

Labels
None yet
Projects
None yet
Milestone
V4.0
Development

No branches or pull requests
2 participants
@it-praktyk @nohwnd