Upstream 6b774f2dfad7f8097b80539db30cfa27a355d299 #9383
Conversation
|
|
||
| return { | ||
| title: $gettext('Blocked pop-ups and redirects'), | ||
| timeout: 20, |
There was a problem hiding this comment.
@elizavetaRa 10s felt too short, so I doubled it. Still quite a lot of text to digest for the average user though
|
Random CI failures.. |
| const { $gettext } = useGettext() | ||
|
|
||
| return { | ||
| title: $gettext('Blocked pop-ups and redirects'), |
There was a problem hiding this comment.
Please use a slightly different title to make clear, that blocking is not a feature but that the app detected, that pop ups are getting blocked:
"Pop-up and redirect block detected"
| timeout: 20, | ||
| status: 'warning', | ||
| desc: $gettext( | ||
| 'Some features might not work correctly. Please enable pop-ups and redirects in Settings > Privacy & Security > Site Settings > Permissions' |
There was a problem hiding this comment.
Please use a more generic message that applies to all browsers:
"Please turn on pop-ups and redirects in your browser settings to make sure everything works right."
pascalwengerter
force-pushed
the
feature/9377
branch
from
60b2af1 to
3a6a8a7
Compare
|
SonarCloud Quality Gate failed.
|
Related Issue