CERNBox WebUI Merge Project #9159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already merged upstream.
Ported from upstream.
Alternative upstream exists
Already merged upstream.
Updates the sidebar links, available via CernFeatures flag. This has already been merged upstream.
Alternative exists upstream to collapse the breadcrumb
Ongoing work upstream
This is being worked on in upstream, with a proper fix for "hasPriority"
New shared with me view with show/hide instead of accept/reject Improvements to sidebar sharing: * Renames "Public links" to "Share publicly" * Adds icon to role selected for better understanding * Adds direct link for internal shares The change to accept/reject has been discussed and approved by oC
Currently, hardcoded to disable all above home/project root. The discussed solution with oC is for actions to be enabled depending on dav response' permission bits
Bug in upstream
Half working, as it doesn't work with pagination
To better distinguish between name, username, email
Required to auto-opening an app on single file view. Since this functionality looks like is available upstream, this commit might not be needed any longer.
So that we do not become the user in public links, which would generate wrong requests when a user is logged in. Reported in owncloud#8486
This commit is a workaround of the lack of spaces in our Reva backend. The idea was to implement the URL schema that we agreed in the past and to re-use the spaces logic for showing our EOS Projects.
Should be replaced by the extension system, allowing us to add entries to the left menu.
By mistake we assumed the apps would also use "spaces" in the url. This is to redirect bookmarked links to the new format. Should be possible to replace whether by integrating it in our "redirector" extension, or by injecting JS via the new functionality upstream.
Use localstorage to store the token for persistency Reduces dependency on SSO Was discussed with oC and the proposal was to have a session system in the backend.
Reduced functionality depending on user account type.
Our Reva backend doesn't implement it yet
For better debugability and support. If we still don't want to show errors to user, this should become a flag enabable feature.
When opening the single file view, it automatically opens the default app. It was discussed that this would not come upstream, but apparently it's already there...
Because our Reva backend doesn't implement the settings API
To avoid updating the document if the user only wants to read.
This enables users to set notifications on shares, in order to know when someone edits a file. It's missing the UI integration for displaying, for now it only generates emails.
EOS Projects should not be returned as being shared, but they are in the current Reva implementation... Or they belong to the user like the rest, or then we need to expose them in the shared with the user ocs response
Badly formed response was causing frontend to crash
While api not implemented on our Reva banckend
Should be fixed in the backend
Shares will always appear as a space, which breaks opening single files shares with apps. It breaks because web was supposed to redirect to the universal url (all files), instead of a "share" url. I consider this to be broken in upstream, as this redirection was supposed to be supported.
oC is doing its own implementation This commit has 2 different attempts and both should be ignored in favor of the new upstream implementation.
To avoid support tickets
The issue was that users were losing the redirection state when they need to login again (go to the SSO and back). A proper fix needs to keep track of original destination in all cases, including the redirection to the SSO from a public link. To test this issue, we just need to "break" the refresh token and update the expiration of the auth token, forcing web to re-authenticate.
Should be moved to extension
labkode
changed the title
| @@ -33,6 +33,12 @@ export default defineComponent({ | |||
| ...mapMutations('runtime/spaces', ['UPSERT_SPACE']), | |||
| ...mapMutations('Files', ['UPSERT_RESOURCE', 'UPDATE_RESOURCE_FIELD']), | |||
|
|
|||
| onNewProjectButtonClick() { | |||
| window.open( | |||
There was a problem hiding this comment.
Note for whoever ends up working on this to add an if-else containing the new functionality from #9383
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR freezes the set of patches for the WebUI merge project as of 6th June 2023.
This PR will not be rebased on top of current upstream head.
This PR provides a code-level view of all the patches in CERNBox WebUI fork
Refer to ownCloud management @hodyroff for more information