Upstream 6b774f2dfad7f8097b80539db30cfa27a355d299

changelog/unreleased/enhancement-pop-up-redirect-blocker-notification

@@ -0,0 +1,7 @@
+Enhancement: User notification for blocked pop-ups and redirects
+
+We have added some functionality that reminds the user to check their browser settings
+so that redirects and e.g. opening a resource in a new tab can work properly.
+
+https://github.com/owncloud/web/issues/9377
+https://github.com/owncloud/web/pull/9383

packages/web-app-files/src/composables/actions/files/useFileActions.ts

@@ -12,7 +12,8 @@ import {
   Action,
   FileAction,
   FileActionOptions,
-  useIsSearchActive
+  useIsSearchActive,
+  useWindowOpen
 } from 'web-pkg/src/composables/actions'
 
 import {
@@ -48,6 +49,8 @@ export const useFileActions = ({ store }: { store?: Store<any> } = {}) => {
     return !!unref(appProviders).find((appProvider) => appProvider.enabled)
   })
 
+  const { openUrl } = useWindowOpen
+
   const { actions: acceptShareActions } = useFileActionsAcceptShare({ store })
   const { actions: copyActions } = useFileActionsCopy({ store })
   const { actions: deleteActions } = useFileActionsDelete({ store })
@@ -190,11 +193,8 @@ export const useFileActions = ({ store }: { store?: Store<any> } = {}) => {
     if (configuration.options.openAppsInTab) {
       const path = router.resolve(routeOpts).href
       const target = `${editor.routeName}-${filePath}`
-      const win = window.open(path, target)
-      // in case popup is blocked win will be null
-      if (win) {
-        win.focus()
-      }
+
+      openUrl(path, target, true)
       return
     }
 
@@ -327,7 +327,7 @@ export const useFileActions = ({ store }: { store?: Store<any> } = {}) => {
     } as any
 
     // TODO: Let users configure whether to open in same/new tab (`_blank` vs `_self`)
-    window.open(router.resolve(routeOpts).href, '_blank')
+    openUrl(router.resolve(routeOpts).href, '_blank')
   }
 
   return {

packages/web-pkg/src/composables/actions/index.ts

@@ -4,3 +4,4 @@ export * from './spaces'
 export * from './types'
 
 export * from './useActionsShowDetails'
+export * from './useWindowOpen'

packages/web-pkg/src/composables/actions/useWindowOpen.ts

@@ -0,0 +1,26 @@
+import { useGettext } from 'vue3-gettext'
+import { useStore } from 'web-pkg/src/composables'
+
+const openUrl = (url: string, target?: string, shouldFocus?: boolean) => {
+  const { $gettext } = useGettext()
+  const store = useStore()
+
+  const win = window.open(url, target)
+
+  if (!win) {
+    store.dispatch('showMessage', {
+      title: $gettext('Pop-up and redirect block detected'),
+      timeout: 20,
+      status: 'warning',
+      desc: $gettext(
+        'Please turn on pop-ups and redirects in your browser settings to make sure everything works right.'
+      )
+    })
+  } else if (shouldFocus) {
+    win.focus()
+  }
+}
+
+export const useWindowOpen = {
+  openUrl
+}