Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gettext and store usage in useWindowOpen composable #9419

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: gettext and store usage in useWindowOpen composable #9419

merged 1 commit into from
Jul 17, 2023

Conversation

JammingBen
Copy link
Contributor

Fixes a regression from #9383.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Jul 17, 2023
@JammingBen JammingBen requested a review from dschmidt July 17, 2023 12:16
@JammingBen JammingBen changed the base branch from master to stable-7.1 July 17, 2023 12:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 3b73517 into stable-7.1 Jul 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-use-window-open-composable branch July 17, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lookacat lookacat lookacat approved these changes

@dschmidt dschmidt dschmidt approved these changes

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @dschmidt @lookacat