[full-ci] Resolve alias links #7405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/29019/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/29019/tracing/public-link-alice-2022-10-11-07-22-54.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/web/29019/tracing/public-link-anonymous-2022-10-11-07-23-14.zip |
JammingBen
changed the title
JammingBen
changed the title
JammingBen
force-pushed
the
resolve-alias-links
branch
from
171f09e to
b9d4aec
Compare
AlexAndBear
changed the title
kulmann
requested changes
Aug 16, 2022
packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue
Outdated
Show resolved
Hide resolved
|
I've fixed the issue with resolving single files. However, currently there is no way to retrieve the file name in such case, so the IDs get used:
Backend team is aware and working on it. I don't know if it needs further adjustments in Web (probably yes), but IMO the PR is fine as alias links are disabled by default anyways. |
JammingBen
force-pushed
the
resolve-alias-links
branch
from
2a36a1d to
557fbf1
Compare
kulmann
requested changes
Aug 23, 2022
packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
resolve-alias-links
branch
from
557fbf1 to
d78ed98
Compare
JammingBen
commented
Aug 23, 2022
JammingBen
force-pushed
the
resolve-alias-links
branch
from
18c523e to
d7c9226
Compare
|
SonarCloud Quality Gate failed. |
|
Currently blocked until cs3org/reva#3179 has been brought to ocis |
dschmidt
reviewed
Aug 29, 2022
| @@ -571,6 +554,25 @@ export default defineComponent({ | |||
| status: 'danger' | |||
| }) | |||
| }) | |||
| }, | |||
|
|
|||
| getAvailableRoleOptions(link) { | |||
packages/web-app-files/src/components/SideBar/Shares/Links/DetailsAndEdit.vue
Show resolved
Hide resolved
packages/web-app-files/src/services/folder/spaces/loaderPersonal.ts
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
resolve-alias-links
branch
from
3058160 to
34016c3
Compare
JammingBen
force-pushed
the
resolve-alias-links
branch
from
9fba893 to
c940681
Compare
JammingBen
force-pushed
the
resolve-alias-links
branch
from
c940681 to
dc8a92e
Compare
JammingBen
force-pushed
the
resolve-alias-links
branch
from
e55cd41 to
fb441fc
Compare
JammingBen
force-pushed
the
resolve-alias-links
branch
from
b0a6e06 to
190685f
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Needs the alias link capability to be set to
truein ocis. See owncloud/ocis#4324 (needs to be reverted after merge).Related Issue
Types of changes
Open tasks:
falseocis#4324 after merge