[full-ci] Resolve internal/private links on shares #7769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
commented
Oct 11, 2022
| if (matchingSpace) { | ||
| path = yield clientService.owncloudSdk.files.getPathForFileId(id) | ||
| resource = yield clientService.webdav.getFileInfo(matchingSpace, { path }) | ||
| } else { |
There was a problem hiding this comment.
Since reviewing renamed files is not such a good UX: the else block (+ 2 additional functions below) is new. getting path and resource for files within own spaces has been moved to the if block above. The rest is untouched.
|
SonarCloud Quality Gate failed. |
|
killer! this issue pains me every time I use public links on a known instance. its not just annoying but really contraproductive when it comes to establishing ocis as the single source of truth for data. awwwesome 🌟 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the (a little bit hacky) ability to resolve private links / public links with "internal" role which point to files/folders within an accepted incoming share.
Related Issue
Types of changes
Checklist: