"Create and copy public link to clipboard" generates an invalid link

[algihu]

"Create and copy public link to clipboard" generates an invalid link

Describe the bug

Using the Windows desktop app pointed to an OCIS instance, when I right-click on a synced file in Windows and select "Create and copy public link to clipboard" a link is generated and copied to the clipboard but when browsing to that link an "Unknown error" is returned.

Steps to reproduce

Steps to reproduce the behavior:

1. Set up ownCloud Desktop App (Windows) pointed to an OCIS server
2. In Windows Explorer navigate to any file in ownCloud and right-click on it
3. In the context menu, select ownCloud-->Create and copy public link to clipboard
4. Open a web browser (I used Chrome) and paste/navigate to the URL that was copied to your clipboard.

Expected behavior

The browser should load a page where you can view/download the file

Actual behavior

Although a link gets generated and copied to the clipboard, when I view the file's properties I can see that no link was actually associated with this file and when I try to navigate to the URL a page is show that says "Unknown error"

Here is a video showing this behavior:

Setup

Installed/Started OCIS 2.0.0-beta.5 using the quick start guide here: https://doc.owncloud.com/ocis/next/quickguide/quickguide.html

Installed ownCloud Desktop App 2.10.1 (build 7187) and configured it to sync as virtual files to my OCIS instance.

Created a folder with some pictures in it.

Additional context

I can generate a valid link using the dialog that opens when I select ownCloud-->Share. After clicking that option I select the "Public Links" tab, click on the "Create new..." option and then click the "Create" button. I then click the "..." next to the newly created Public Link and select "Copy Link to Clipboard" and then paste/navigate to that link in a browser, This successfully allows me to access the file.

Here is a video showing this working successfully.

[michl19]

@michaelstingl can you have a look into this as well. We're unsure if it's desktop or backend.

[michaelstingl]

We're unsure if it's desktop or backend.

Maybe desktop. Something's 🐟 -y. I'll have a look tomorrow…

[kulmann]

What kind of permissions does the public link have? We've introduced so called Internal links, which have a permission bitmask of 0. Those are supposed to resolve into the correct shared location in the authenticated context of the user.

If the created link has permissions 0 then I'd have an explanation for the issue described above: Resolving internal links is not yet supported in ownCloud Web - support is coming with owncloud/web#7405 which is close to being merged.

If it's a link with permissions > 0 then I have no idea, yet.

[michaelstingl]

Because of #4445 , Desktop sync client 2.11 tries to create a link with todays expiration date, and because of #4446 , the link creation fails silently.

[michaelstingl]

No idea why both ways behave different in the desktop sync client. I opened an issue for further investigation: owncloud/client#10057

[C0rby]

@michaelstingl, can you still reproduce this? I can't but I'm testing it on Linux since I don't have Windows.

[kulmann]

Should have been fixed with #4475

[C0rby]

Cool so I can close this issue?

[kulmann]

yes 😁 @algihu please re-open if the issue is not fixed for you with ocis v2.0.0-beta.8

[algihu]

I just tested it again with v2.0.0-beta.8 and this feature now works correctly.

[kulmann]

I just tested it again with v2.0.0-beta.8 and this feature now works correctly.

Thanks for investing the time ❤️ Glad to hear that it's fixed 👍