Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the alias link capability to false #4324

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

JammingBen
Copy link
Contributor

Description

We can't resolve alias links in Web yet, but creating those will be possible within the next few days. Hence we figured it would be best to temporarily set the alias link capability to false (see owncloud/web#7133 (comment)).

@JammingBen JammingBen requested review from kulmann and kobergj August 3, 2022 10:19
@JammingBen JammingBen self-assigned this Aug 3, 2022
@update-docs
Copy link

update-docs bot commented Aug 3, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kobergj
Copy link
Collaborator

kobergj commented Aug 3, 2022

@JammingBen @kulmann Sorry simple question for my understanding: Why is it needed to set this to false? As far as I understand capabilities should reflect the capabilities of the server, not of the client. Or do I misunderstand?

@kulmann
Copy link
Contributor

kulmann commented Aug 3, 2022

@JammingBen @kulmann Sorry simple question for my understanding: Why is it needed to set this to false? As far as I understand capabilities should reflect the capabilities of the server, not of the client. Or do I misunderstand?

Yes, capabilities of the server. Web as a client checks if the alias capability is true, if yes then we offer the option to create an alias link. The feature is not complete in web, only creating but not resolving alias links is implemented. We can either flip the capability to false until we have the resolving implemented (what this PR does) or disable the feature temporarily in web (would be a PR in web). I get what you mean, since it's an issue of web the code change should happen in web. I'm fine with that as well. Since only web is about to implement the feature at all it's probably not that big of an issue. But handling it only in web would be more strict.

Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Since it is temporary I'm absolutely fine with the change. Was just curious 😄

@kulmann kulmann merged commit ee2378b into master Aug 3, 2022
@delete-merged-branch delete-merged-branch bot deleted the alias-link-capability-to-false branch August 3, 2022 11:15
ownclouders pushed a commit that referenced this pull request Aug 3, 2022
Merge: a021393 492ac5c
Author: Benedikt Kulmann <[email protected]>
Date:   Wed Aug 3 13:15:37 2022 +0200

    Merge pull request #4324 from owncloud/alias-link-capability-to-false

    Set the alias link capability to `false`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants