[full-ci] Delete resharing tests #8704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScharfViktor
force-pushed
the
deleteResharingTests
branch
from
c5f9659 to
eee53bf
Compare
ScharfViktor
force-pushed
the
deleteResharingTests
branch
2 times, most recently
from
51312cb to
85c471b
Compare
ScharfViktor
force-pushed
the
deleteResharingTests
branch
from
c389fcd to
7cc0c1f
Compare
ScharfViktor
requested review from
wkloucek,
micbar,
phil-davis and
individual-it
as code owners
delete re-sharing tests
ScharfViktor
force-pushed
the
deleteResharingTests
branch
from
baf8ad9 to
178fdfc
Compare
|
| @@ -18,7 +18,7 @@ OC_CI_PHP = "owncloudci/php:%s" | |||
| OC_CI_WAIT_FOR = "owncloudci/wait-for:latest" | |||
| OC_CS3_API_VALIDATOR = "owncloud/cs3api-validator:0.2.1" | |||
| OC_LITMUS = "owncloudci/litmus:latest" | |||
| OC_OC_TEST_MIDDLEWARE = "owncloud/owncloud-test-middleware:1.8.8" | |||
| OC_OC_TEST_MIDDLEWARE = "owncloud/owncloud-test-middleware:latest" | |||
There was a problem hiding this comment.
I would suggest to leave it pinned to a particular version
There was a problem hiding this comment.
| _, ok := res.GetRolesOk() | ||
| Expect(ok).To(BeTrue()) | ||
| }) | ||
| // that is resharing test. Please delete after disable resharing feature |
There was a problem hiding this comment.
do we want to merge the PR with that commented code?
There was a problem hiding this comment.
yes, we want to delete all resharing code and all resharing unit tests after merging this PR
cc @kobergj
There was a problem hiding this comment.
The commented out code will be removed in following PRs
see here https://github.com/owncloud/ocis/issues/8744
saw-jan
reviewed
Mar 27, 2024
tests/acceptance/features/apiSpacesDavOperation/fileVersionByFileID.feature
Show resolved
Hide resolved
saw-jan
approved these changes
Mar 27, 2024
7 tasks
9 tasks
ownclouders
pushed a commit
that referenced
this pull request
Mar 27, 2024
* feat: disable resharing by default delete re-sharing tests * fix tests --------- Co-authored-by: Michael Barz <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding:
e2e tests are blocked until it is merged #8736