[full-ci] Delete resharing tests #8704
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Change: Disable resharing by default for deprecation | ||
|
|
||
| We disabled the resharing feature by default. This feature will be removed from the product in the next major release. The resharing feature is not recommended for use and should be disabled. Existing reshares will continue to work. | ||
|
|
||
| https://github.com/owncloud/ocis/pull/8653 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -731,36 +731,37 @@ var _ = Describe("Driveitems", func() { | |
| _, ok := res.GetExpirationDateTimeOk() | ||
| Expect(ok).To(BeFalse()) | ||
| }) | ||
| // that is resharing test. Please delete after disable resharing feature | ||
|
There was a problem hiding this comment. do we want to merge the PR with that commented code? There was a problem hiding this comment. yes, we want to delete all resharing code and all resharing unit tests after merging this PR There was a problem hiding this comment. The commented out code will be removed in following PRs |
||
|
|
||
| // It("updates the share permissions with changing the role", func() { | ||
| // getPublicShareMockResponse.Share = nil | ||
| // getPublicShareMockResponse.Status = status.NewNotFound(ctx, "not found") | ||
| // updateShareMock := gatewayClient.On("UpdateShare", | ||
| // mock.Anything, | ||
| // mock.MatchedBy(func(req *collaboration.UpdateShareRequest) bool { | ||
| // return req.GetShare().GetId().GetOpaqueId() == "permissionid" | ||
| // }), | ||
| // ) | ||
| // updateShareMock.Return(updateShareMockResponse, nil) | ||
| // driveItemPermission.SetRoles([]string{unifiedrole.NewViewerUnifiedRole(false).GetId()}) | ||
| // body, err := driveItemPermission.MarshalJSON() | ||
| // Expect(err).To(BeNil()) | ||
| // svc.UpdatePermission( | ||
| // rr, | ||
| // httptest.NewRequest(http.MethodPatch, "/", strings.NewReader(string(body))). | ||
| // WithContext(ctx), | ||
| // ) | ||
| // Expect(rr.Code).To(Equal(http.StatusOK)) | ||
| // data, err := io.ReadAll(rr.Body) | ||
| // Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| // res := libregraph.Permission{} | ||
|
|
||
| // err = json.Unmarshal(data, &res) | ||
| // Expect(err).ToNot(HaveOccurred()) | ||
| // _, ok := res.GetRolesOk() | ||
| // Expect(ok).To(BeTrue()) | ||
| // }) | ||
| It("fails to update the share permissions for a file share when setting a space specific role", func() { | ||
| getPublicShareMockResponse.Share = nil | ||
| getPublicShareMockResponse.Status = status.NewNotFound(ctx, "not found") | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to leave it pinned to a particular version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
owncloud/owncloud-test-middleware#143 (comment)