Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting re-sharing from the code base #8842

Closed
6 of 7 tasks
ScharfViktor opened this issue Mar 27, 2024 · 5 comments
Closed
6 of 7 tasks

Deleting re-sharing from the code base #8842

ScharfViktor opened this issue Mar 27, 2024 · 5 comments
Labels

Comments

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Mar 27, 2024

resharing feature is not supported anymore: https://github.com/owncloud/docs-ocis/pull/739/files#diff-04cd79e526c8a7f0162d8fc5bc5fa8c501fe9e5899024268837c05a74349b26cR148-R149

cc @kobergj @saw-jan

@ScharfViktor ScharfViktor changed the title Deleting re-sharpening from the code base Deleting re-sharing from the code base Mar 27, 2024
@kobergj kobergj self-assigned this Apr 2, 2024
@kobergj
Copy link
Collaborator

kobergj commented Apr 3, 2024

New finding: Web defaults to resharing=true if no capability is given. This should be changed to false, so ocis can omit sending resharing capability.

@kobergj
Copy link
Collaborator

kobergj commented Apr 5, 2024

@ScharfViktor @kulmann do we need some changes also in web? Or we stick with current implementation? From a server side point of view this ticket can be closed.

@kobergj kobergj removed their assignment Apr 5, 2024
@ScharfViktor
Copy link
Contributor Author

@ScharfViktor @kulmann do we need some changes also in web? Or we stick with current implementation? From a server side point of view this ticket can be closed.

now /ocs/v1.php/cloud/capabilities?format=json request returns "resharing":false .

Screenshot 2024-04-08 at 10 57 09

to completely delete resharing we need to remove the resharing from the web and client and the last step from the server capability request (Expect: no value "resharing":true/false in the capabilities response)

@kulmann I transferred the ticket to the web so I don't have to close it here and create a new one on the web.

@ScharfViktor ScharfViktor transferred this issue from owncloud/ocis Apr 8, 2024
@micbar
Copy link
Contributor

micbar commented Apr 12, 2024

I would prefer to close this ticket and create a follow up for web to keep the sprint clean.

@micbar micbar transferred this issue from owncloud/web Apr 12, 2024
@micbar
Copy link
Contributor

micbar commented Apr 12, 2024

Follow up here owncloud/web#10771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants