Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Resharing config #8653

Closed
wants to merge 2 commits into from
Closed

[full-ci] Resharing config #8653

wants to merge 2 commits into from

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Mar 14, 2024 •
edited
Loading

Description

Disable resharing by default.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Mar 14, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar changed the base branch from master to stable-5.0 March 14, 2024 15:39
@micbar micbar force-pushed the resharing-config branch from 643f1c6 to 3b207a6 Compare March 14, 2024 15:39
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

ScharfViktor
ScharfViktor approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. it works correct

all tests are green except of the unit tests (I don't know how fix it)

@micbar
Copy link
Contributor Author

micbar commented Mar 14, 2024

For me, this feels like we are invalidating all testing with that move. I would shift that to 5.1.0

@ScharfViktor
Copy link
Contributor

config was changed here #8704

@ScharfViktor ScharfViktor deleted the resharing-config branch April 17, 2024 08:58
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@wkloucek wkloucek Awaiting requested review from wkloucek wkloucek is a code owner

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@kulmann kulmann Awaiting requested review from kulmann

@2403905 2403905 Awaiting requested review from 2403905

@kobergj kobergj Awaiting requested review from kobergj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micbar @ScharfViktor