Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM. search for federated users doesn't contain ocis instance info #9813

Closed
ScharfViktor opened this issue Aug 14, 2024 · 1 comment · Fixed by #9819
Closed

OCM. search for federated users doesn't contain ocis instance info #9813

ScharfViktor opened this issue Aug 14, 2024 · 1 comment · Fixed by #9819
Assignees
Labels

Comments

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Aug 14, 2024

related:
#9788
#9702
#9735

Steps:

Given using server "LOCAL"
And "Alice" has created the federation share invitation
And using server "REMOTE"
And "Brian" has accepted invitation
When user "Brian" searches for federated user "ali" using Graph API

Actual: response doesn't contain info about ocis instance (no identities section).
Screenshot 2024-08-14 at 16 47 51

Expected: response contains identities section to understand which ocis instance this user is from.

"identities": [
                {
                    "issuer": "federation-ocis-server",
                    "issuerAssignedId": "b49ed57c-c562-4740-a5be-4ebc8b947100"
                }
            ]

This can be useful if we will be sharing more than 2 ocis instances to separate users (this can be in case of same names)

CC @rhafer @tbsbdr

@phil-davis phil-davis changed the title OCM. search for federated users doesn't ocis instance info OCM. search for federated users doesn't contain ocis instance info Aug 14, 2024
@phil-davis
Copy link
Contributor

Yes, there will need to be some way to present a UI so that a user can distinguish which federated instance each user comes from. The API response probably needs to have a federated domain name (or something similar), and then someone needs to think about how best to present something in client UIs that will be user-friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants