Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCM. Identify federated users #9702

Closed
ScharfViktor opened this issue Jul 11, 2024 · 5 comments
Closed

OCM. Identify federated users #9702

ScharfViktor opened this issue Jul 11, 2024 · 5 comments
Assignees
@rhafer
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug

Comments

@ScharfViktor
Copy link
Contributor

precondition:

Steps:

  • create federation connection between admin(ocis-server) and marie(federation-ocis-server)
  • admin searches users by mar in the Share with people dialog

Actual: admin gets two marie users. but we cannot identify which one is the federated user
Screenshot 2024-07-11 at 10 58 21

Expected: federated user has different icon
@kulmann
Copy link
Member

kulmann commented Jul 15, 2024

Note: we had this for the share type prop in ocs. Simply wasn't built, yet, based on the new attributes in the graph api.

@tbsbdr tbsbdr added Type:Bug Priority:p2-high Escalation, on top of current planning, release blocker labels Jul 26, 2024
@tbsbdr tbsbdr transferred this issue from owncloud/web Jul 29, 2024
@tbsbdr tbsbdr changed the title OCM. Identify federated users on a web page OCM. Identify federated users Jul 29, 2024
@rhafer rhafer self-assigned this Aug 6, 2024
@rhafer rhafer moved this from Backlog to In progress in Infinite Scale Team Board Aug 6, 2024
@butonic butonic mentioned this issue Aug 6, 2024
Closed
2 tasks
@butonic
Copy link
Member

butonic commented Aug 6, 2024

@rhafer will add 'Federated' (OCM user, has no password and cannot login, only serves as a reference for shares) the userType property of a user, in addition to Member (of the instance) and Guest (invited by invites service).

rhafer added a commit to rhafer/ocis that referenced this issue Aug 7, 2024
@rhafer
(fix)graph: Always set UserType in /users responses
60f907f 
LDAP users without a UserType attribute get the UserType "Member"
by default. Federated users get the UserType "Federated".

Related owncloud#9702
@rhafer rhafer mentioned this issue Aug 7, 2024
Merged
rhafer added a commit to rhafer/ocis that referenced this issue Aug 7, 2024
@rhafer
(fix)graph: Always set UserType in /users responses
dc299a0 
LDAP users without a UserType attribute get the UserType "Member"
by default. Federated users get the UserType "Federated".

Related owncloud#9702
@rhafer
Copy link
Contributor

rhafer commented Aug 8, 2024

I created owncloud/libre-graph-api#190 to document the new usertype Federated.

rhafer added a commit that referenced this issue Aug 12, 2024
@rhafer
(fix)graph: Always set UserType in /users responses
80e8a2e 
LDAP users without a UserType attribute get the UserType "Member"
by default. Federated users get the UserType "Federated".

Related #9702
rhafer added a commit to rhafer/ocis that referenced this issue Aug 12, 2024
@rhafer
(fix)graph: Always set UserType in /users responses
cb38700 
LDAP users without a UserType attribute get the UserType "Member"
by default. Federated users get the UserType "Federated".

Related owncloud#9702
rhafer added a commit to rhafer/ocis that referenced this issue Aug 12, 2024
@rhafer
feat(graph): add support for filtering users by type
7f04956 
This add support for equality filters on the `userType` property of users
for the /users endpoint.

It also changes the behavior of the /users endpoint to only return
federated users when explicitly request via a `userType` filter.

E.g. to search for federated users with matching "albert" you can use:

`$filter=userType eq 'Federated'&$search="albert"`

Related Issue: owncloud#9702
@rhafer rhafer mentioned this issue Aug 12, 2024
Merged
rhafer added a commit to rhafer/ocis that referenced this issue Aug 12, 2024
@rhafer
feat(graph): add support for filtering users by type
b78352c 
This add support for equality filters on the `userType` property of users
for the /users endpoint.

It also changes the behavior of the /users endpoint to only return
federated users when explicitly request via a `userType` filter.

E.g. to search for federated users with matching "albert" you can use:

`$filter=userType eq 'Federated'&$search="albert"`

Related Issue: owncloud#9702
rhafer added a commit to rhafer/ocis that referenced this issue Aug 13, 2024
@rhafer
feat(graph): add support for filtering users by type
84bb427 
This add support for equality filters on the `userType` property of users
for the /users endpoint.

It also changes the behavior of the /users endpoint to only return
federated users when explicitly request via a `userType` filter.

E.g. to search for federated users with matching "albert" you can use:

`$filter=userType eq 'Federated'&$search="albert"`

Related Issue: owncloud#9702
rhafer added a commit to rhafer/ocis that referenced this issue Aug 13, 2024
@rhafer
feat(graph): add support for filtering users by type
9a08464 
This add support for equality filters on the `userType` property of users
for the /users endpoint.

It also changes the behavior of the /users endpoint to only return
federated users when explicitly request via a `userType` filter.

E.g. to search for federated users with matching "albert" you can use:

`$filter=userType eq 'Federated'&$search="albert"`

Related Issue: owncloud#9702
rhafer added a commit to rhafer/ocis that referenced this issue Aug 13, 2024
@rhafer
feat(graph): add support for filtering users by type
23ba6e4 
This add support for equality filters on the `userType` property of users
for the /users endpoint.

It also changes the behavior of the /users endpoint to only return
federated users when explicitly request via a `userType` filter.

E.g. to search for federated users with matching "albert" you can use:

`$filter=userType eq 'Federated'&$search="albert"`

Related Issue: owncloud#9702
@ScharfViktor ScharfViktor mentioned this issue Aug 14, 2024
Closed
@JammingBen
Copy link
Contributor

Is there something left to do here, other than the correlating web issue owncloud/web#11361?

@rhafer
Copy link
Contributor

rhafer commented Aug 22, 2024

@JammingBen I don't think so. So I guess this can be closed.

@rhafer rhafer closed this as completed Aug 22, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhafer rhafer

Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Infinite Scale Team Board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rhafer @butonic @kulmann @tbsbdr @JammingBen @ScharfViktor