Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph: add identities property to non-admin response of GetUsers #9819

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Aug 15, 2024

Fixes: #9813

@rhafer rhafer self-assigned this Aug 15, 2024
Copy link

update-docs bot commented Aug 15, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@rhafer
Copy link
Contributor Author

rhafer commented Aug 15, 2024

Hm, I just noticed that the demo users don't have the 'Identities' value configured yet. I'll add a fix.

@rhafer rhafer requested a review from ScharfViktor August 15, 2024 09:19
@ScharfViktor
Copy link
Contributor

  • I switched to your branch
  • make -C ocis clean generate build
  • run test TEST_SERVER_URL="https://ocis-server:9200" TEST_SERVER_FED_URL="https://federation-ocis-server:10200" BEHAT_FEATURE="tests/acceptance/features/apiOcm/searchFederationUsers.feature:16" make test-acceptance-api

Actual: response doesn't contain identities
image

@rhafer
Copy link
Contributor Author

rhafer commented Aug 15, 2024

Actual: response doesn't contain identities

Currently only federated users are guaranteed to have the identities property. Users of type Member only have identities if explicitly set when creating them.

I guess we should adjust that so that the identities property is automatically populated when creating a user.

To make sure they get and 'identities' property in the graph responses.
Copy link

@ScharfViktor
Copy link
Contributor

now it's work 👍 thank you
image

@ScharfViktor
Copy link
Contributor

Hm, I just noticed that the demo users don't have the 'Identities' value configured yet. I'll add a fix.

tested it. works fine 👍

I'll merge your PR and change my tests #9812

@ScharfViktor ScharfViktor merged commit f6e6250 into owncloud:master Aug 15, 2024
3 checks passed
ownclouders pushed a commit that referenced this pull request Aug 15, 2024
graph: add identities property to non-admin response of GetUsers
ownclouders pushed a commit that referenced this pull request Aug 16, 2024
graph: add identities property to non-admin response of GetUsers
ownclouders pushed a commit that referenced this pull request Aug 16, 2024
graph: add identities property to non-admin response of GetUsers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OCM. search for federated users doesn't contain ocis instance info
2 participants