Collection OCM Bugs and refinements (WIP)

[tbsbdr]

Collection

as discussed today; needs refinement - work in progress. writing down notes here for better visibility. (ticket is not yet actionable). some items might be obsolete due to @ScharfViktor s work. if so, please ignore them.

Most important Issues on top (imo):

Urgent and important:

• OCM. Restrict sharing roles to Editor / Viewer in sharing dialog #9745
  • libre graph query added in add permissions $filter and $select libre-graph-api#191
  • api changes implemented in allow querying federated sharing roles #9765
  • web external/internal switch feat: external collaborator search filter web#11351
• OCM. Admin Settings > Users: indicate which account is a federated account ++ remove actions from users. #9747
  • libre graph spec change added with Add "Federated" as a new user type libre-graph-api#190
  • api changes implemented in feat(graph): add support for filtering users by type #9788
  • web: Distinguish federated users from internal users web#11361
• save ocm providers config file to config path (not user space)  #9778
• New variable like OCIS_ENABLE_OCM should summarize most of the variable to simplify enablement of ocm add OCIS_ENABLE_OCM env var #9784
• add documentation (admin & user)
  • readme update in [docs-only] update ocm service readme #9814
  • api description needs rework? maybe just reference external documentation as sciencemesh is a different project.
• Rename ScienceMesh App
  • jfd: to what? Isn't thisn specific to the sciencemesh? so ... why rename?
  • tbsbdr: hm.. yes, agree. the idea was to make it more generic eg. for non-scientific usecases (school, eu-governments etc.) but lets keep it as is for now and bring it up again if requested.
  • jfd: maybe sciencemesh? to make it more specific? I'd prefer to use a spaces based solution for our generic federated sharing. IMO we can and should leave public link based sharing behind.
• Rename "Institution"
  • jfd: to what? Maybe 'Domain'? Migth be too technical ... on the other hand might ok for the target audience. We might have to check the Sciencemesh conepts and naming. Then again: why rename if this is a sciencemash specific term anyway?
  • tbsbdr: same like above.
  • jw: the term "institution" is "the ocmprovider of the invitation" - The equivalence of these terms is no where to be seen. This adds confusion.
  • jfd: I found the docs for the GOCDB site object, which has a domain property that has to match the domain in the config ... without a protocol.
• invite grantedTo should get an @libreGraph indicator for the user type
• /permissions endpoint does not return federated shares (Permissions endpoint is not listing federated shares #9898)

---

Later, not so urgent:

• [OCM] SharedByMe / SharedWithOthers is missing resources that have been shared externally #9908
• Shares: Shared with me: Avatars should be visible
  • permissions of an ocm share doeas not have a roles property
• Shared with me filtering by type federated does not work
• institutions drop down menu is hidden behind elements below #9806
• ScienceMesh app: refresh shows white screen web#11358
• sciencemesh generate token does not show expiry date
• #10014
• desktop (and mobile clients): do not sync.
  • maybe because we did not provide an etag. might be fixed with ocm: return remote etag cs3org/reva#4823
• federated shares cannot be updated (sharing role / expiry date) #9926
• OCM. generation invitation doesn't send email #9583
• generate a dedicated uuid for federated users instead of using the one from the remote instance #9927
  • store uuid mapping in ocm
  • populate user identities with correct issuer + remoteid
• test what happens when two federated shares with the same name are created. how does the propfind look? do we deduplicate the names?
• Shares: "Hide" returns an error [QA][OCM] Hide & Enable Sync fail with received federated shares #10719
• Shares: "Disable Sync" returns an error - requires implementing mountpoints [QA][OCM] Hide & Enable Sync fail with received federated shares #10719
• OCM. user cannot see inviteUser email  #9591
• deleting a federated connection in the sciencemesh app has no effect. returns a 200OK response but reloading the app still shows the connection (OCM. user cannot delete accepted user web#11688)
• OCM. sharing issues #9534 (maybe fixed by now?)
  • ocm: return remote etag cs3org/reva#4823 return etag in propfind
• configfile ocmproviders: "domain" must be robust and work regardless if with or without https or trailing slashes
  • should be fixed with https://github.com/owncloud/ocis/pull/9765/files/966b4e142272e34f904abd0d4ecc34b6a35156ee#diff-462196e0833e494a969866c68d1f714c5ca516085de07f99f5b23113d9c44334R286
  • add go cli tool to fgenerate ocmproviders.json file
• "Generate invitation" works only if there is already a ocmprovider entered
  • generating works, but the ocmproviders must be configured by the admin beforehand. if they are not ... there is no sciencemesh app anyway. or at least it should be disabled.
  • accepting the invite token requires selecting the provider, even if only one is available ... maybe preselect one?
• General: Need for OCM 2.0?
• discovery: implement OCM wellknown for discovery cs3org/reva#4809
• OCM. Prevent federated users from being added as members of the space #10051
• OCM. Prevent adding external users to space web#11579
• OCM. delete-accepted-user endpoint always returns 200 #10223
• OCM. user loses the first share #10222
• OCM. federated connection is not dropped when one of the users deletes the connection #10216
• OCM. server crash after deleting share for ocm user #10213
• [QA] OCM: inviting user has no hint to also pass his 'institution' to thre receiver #10209
• [QA] OCM: failing invite produces no readable error messge #10208
• OCM federation sharing issue #10025
• OCM. federated user cannot open shared folder web#11753
• OCM. Removing a federated share does not update the resource's share-types #10262
• [OCM] sharee cannot access the federation shares via normal webdav paths #10536
• [QA] OCM - images (& thumbnails) are completely broken with OCM #10272
• [OCM] federation shares missing name and root.remoteItem values in the drives list #10689
• ocm. user cannot change share role web#11991
• OCM. [QA] federated user from different instances are indistinguishable when they share the same full name #10734

[tbsbdr]

Sharing

If OCM is enabled, then the search scope must be defined:

• Internal OR External users

Note: we dismissed the idea of having a mix of both user types, as they come with different permission possibilities.

[tbsbdr]

updated ocm wording (skip for now) cc @butonic