Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OCM] sharee cannot access the federation shares via normal webdav paths #10536

Closed
Tracked by #9735
saw-jan opened this issue Nov 11, 2024 · 3 comments
Closed
Tracked by #9735
Labels

Comments

@saw-jan
Copy link
Member

saw-jan commented Nov 11, 2024

Steps to reproduce

  1. Create a federation share of a folder (remoteFolder)
  2. as sharee, try to do PROPFIND
curl -XPROPFIND 'https://ocis-server:9200/remote.php/dav/files/admin/Shares/remoteFolder' -uadmin:admin -vk

curl -XPROPFIND 'https://ocis-server:9200/remote.php/dav/spaces/{shares-space-id}/remoteFolder' -uadmin:admin -vk
< HTTP/1.1 404 Not Found

But the share is accessible using mount-point-id and remote-item-id

# mount-point-id
curl -XPROPFIND 'https://ocis-server:9200/remote.php/dav/spaces/89f37a33-858b-45fa-8890-a1f2b27d90e1$6953d7bc-1c57-4f2a-8977-10bdfbcb2ff6' -uadmin:admin -vk

# remote-item-id
curl -XPROPFIND 'https://ocis-server:9200/remote.php/dav/spaces/89f37a33-858b-45fa-8890-a1f2b27d90e1$6953d7bc-1c57-4f2a-8977-10bdfbcb2ff6!Lw%3D%3D' -uadmin:admin -vk
< HTTP/1.1 207 Multi-Status

Since this is a remote share, maybe the behaviour is expected.

Related: owncloud/web#11753
Web using remote id: owncloud/web#11758

@ScharfViktor
Copy link
Contributor

I can confirm. cc @rhafer

@rhafer
Copy link
Contributor

rhafer commented Nov 11, 2024

curl -XPROPFIND 'https://ocis-server:9200/remote.php/dav/files/admin/Shares/remoteFolder' -uadmin:admin -vk

curl -XPROPFIND 'https://ocis-server:9200/remote.php/dav/spaces/{shares-space-id}/remoteFolder' -uadmin:admin -vk

Both of these can only work for "normal" user and group shares. As requests to these paths are handled by the sharestorageprovider. Federated shares are handled by a different storageprovider.

AFAICS there is currently no way to list received ocm shares via webdav (or access them by mount path). You can get the id via sharedWithMe on the graph service (like web does)

curl -k -u moss:vista  'https://ocis-federation.owncloud.test/graph/v1beta1/me/drive/sharedWithMe'

Then take the id values of the embedded remoteItem.

@saw-jan
Copy link
Member Author

saw-jan commented Nov 12, 2024

yes, remoteItem id from sharedWithMe and mount-point id from me/drives both work.
If this is expected and there will be no further improvements/changes, then we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants