Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] add test to upload file to a shared folder via TUS by federated user #10415

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Oct 25, 2024

Description

This PR adds test to upload a file to a shared folder via TUS by a federated user.

Scenario: federated user upload file to a shared folder via TUS

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-tus-upload branch 3 times, most recently from ce3a92e to 3ec2a4e Compare November 13, 2024 07:08
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-tus-upload branch 11 times, most recently from 8466d85 to 0ecd3f0 Compare November 15, 2024 10:52
@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-tus-upload branch 3 times, most recently from fef6e9d to d93d28d Compare November 21, 2024 07:13
@prashant-gurung899 prashant-gurung899 marked this pull request as ready for review November 21, 2024 08:18
@nirajacharya2
Copy link
Contributor

please revert all changes in tests/acceptance/bootstrap/PublicWebDavContext.php

tests/acceptance/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/bootstrap/SpacesContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/apiOcm/share.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiOcm/share.feature Outdated Show resolved Hide resolved
@issue-10285 @issue-10536
Scenario: local user upload file to a federated shared folder via TUS
Given using spaces DAV path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this matter about spaces dav path in this scenario?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it matters, as we need to hit endpoint with spaceId.
:

if ($davPathVersion === WebDavHelper::DAV_VERSION_SPACES) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we must specify space dav path for federation shares (doesn't work with other dav paths, see #10536). by default new dav path is used in the tests

@prashant-gurung899 prashant-gurung899 force-pushed the tests-ocm-tus-upload branch 2 times, most recently from 9b8b92c to 5516b7d Compare November 21, 2024 11:33
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's 👍 for me.

Copy link

sonarcloud bot commented Nov 22, 2024

@prashant-gurung899 prashant-gurung899 merged commit 1663e1e into master Nov 22, 2024
4 checks passed
@prashant-gurung899 prashant-gurung899 deleted the tests-ocm-tus-upload branch November 22, 2024 05:56
ownclouders pushed a commit that referenced this pull request Nov 22, 2024
[tests-only][full-ci] add test to upload file to a shared folder via TUS by federated user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants