Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCM. Removing a federated share does not update the resource's share-types #10262

Open
Tracked by #9735 ...
JammingBen opened this issue Oct 8, 2024 · 1 comment
Open
Tracked by #9735 ...
Assignees
Labels

Comments

@JammingBen
Copy link
Contributor

Describe the bug

Removing a federated share does not update the resource's share-types.

Steps to reproduce

  1. Share a file that has no shares and links with a federated user
  2. Do a PROPFIND on the resource -> oc:share-types includes 0
  3. Remove the federated share
  4. Do a PROPFIND on the resource again -> oc:share-types still includes 0

Expected behavior

share-types should be empty.

Actual behavior

share-types still includes 0

@rhafer
Copy link
Contributor

rhafer commented Dec 4, 2024

Looks as if we're not removing the ("fake") grant for OCM shares from the storage provider when we're deleting ocm shares. (https://github.com/cs3org/reva/blob/edge/internal/grpc/services/gateway/ocmshareprovider.go#L92)

rhafer added a commit to rhafer/reva that referenced this issue Dec 5, 2024
rhafer added a commit to rhafer/reva that referenced this issue Dec 5, 2024
rhafer added a commit to rhafer/reva that referenced this issue Dec 10, 2024
rhafer added a commit to rhafer/reva that referenced this issue Dec 11, 2024
rhafer added a commit to cs3org/reva that referenced this issue Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

No branches or pull requests

2 participants