Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] update issue tags #10737

Merged
merged 3 commits into from
Dec 10, 2024
Merged

[tests-only] update issue tags #10737

merged 3 commits into from
Dec 10, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Dec 5, 2024

Description

Updated the issue tags and test coverage for etag in federation sharing

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan force-pushed the tests/update-issue-tag branch from 5352c2b to c5d4bdc Compare December 6, 2024 03:54
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saw-jan saw-jan force-pushed the tests/update-issue-tag branch from f6da9bf to 9527f00 Compare December 9, 2024 08:55
@saw-jan saw-jan force-pushed the tests/update-issue-tag branch from 9527f00 to ad2e310 Compare December 9, 2024 11:48
@saw-jan saw-jan requested a review from ScharfViktor December 9, 2024 11:49
Comment on lines +63 to +67
"properties": {
"displayName": { "const": "Alice Hansen" },
"id": { "pattern": "^%federated_user_id_pattern%$" },
"@libre.graph.userType": { "const": "Federated" }
}
Copy link
Member Author

@saw-jan saw-jan Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this format for properties checks. still readable and reduces lines

Copy link

sonarqubecloud bot commented Dec 9, 2024

@saw-jan saw-jan merged commit 6866f5a into master Dec 10, 2024
2 checks passed
@saw-jan saw-jan deleted the tests/update-issue-tag branch December 10, 2024 03:46
ownclouders pushed a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants