[QA] Test coverage for activites api

[amrita-shrestha]

Description

Add tests coverage for activities api https://owncloud.dev/libre-graph-api/#/activities/GetActivities

• GET /v1beta1/extensions/org.libregraph/activities

• web is using this api endpoint ( implemented)

Scenarios:

• check activities on ocm Extend test coverage for ocm #10073

• check activities for events (applicable to files, folders or spaces):

  • Resource (file/folder):

  • Activities. Resource id is missing in the old activities #9712

    • Added [tests-only] [full-ci] Add test to check activity after uploading a file #9678
    • Deleted [tests-only] [full-ci] Test for file deletion activity #9705
    • Moved [tests-only] [full-ci] Test to check move activity of file #9731
    • activities of destination file and folder [QA] Test coverage for activites api #9543 (comment)
      • Moved activities [tests-only][full-ci] add test to check move activities of destination file and folder #10407
      • Copied activities [tests-only][full-ci] add test to check copy activities of destination file and folder #10485
    • Renamed [tests-only] [full-ci] Test for resource(file|folder) rename activity #9743
    • Edited Activities. can not distinguish between edit and uploaded file #10001
      • [tests-only][full-ci] add test to check edit activity for a file #10230
    • [ ] download Activities. no event for downloading file #10007 [Not available yet]
      • (not available for authenticated download) FileDownloaded Activity #10162 (comment)
    • [ ] Unauthenticated download (public download) [Disabled]
      • Activities. no event for downloading file #10007
      • Activities. downloaded activity shown while opening file via public link #10231
      • Disable download activity #10368
    • try to list activities of another user's file Activities. Any user can get the resource's activities using the file-id #9860
      • [tests-only][full-ci] add tests to check api activities of a user's file by any user #10132
    • activities of a folder
      • basic activities [tests-only] [full-ci] Test to check activities of a folder #9796
      • folder rename activities Activity: folder variable missing if folder renamed #10148
        Activity: new renamed folder name shown in previous folder share activity #10210
        - [tests-only][full-ci] add test to check activities of a folder after renaming #10395
      • check if scenario mentioned in Activity parent resource refs #9536 is covered @anon-pradip
        • ❗ Please, state if this has been checked or not
          → Covered in: [tests-only][full-ci] Add test coverage for correct parent folder reference in activity messages #10617

  • Resource (file) - activities using file-id

    • move
      • [tests-only][full-ci] add test to check add, edit, rename & move activities for a file using file-id path #10312
    • move (destination file and folder)
      • [tests-only][full-ci] add test to check activities of destination file and folder by moving a file using file-id #10409
    • copy (destination file and folder)
      • [tests-only][full-ci] add test to check activities of destination file and folder by copying a file using file-id #10534
    • rename Activities. Renaming file with file-id gives move activity instead of rename #9744
      • [tests-only][full-ci] add test to check add, edit, rename & move activities for a file using file-id path #10312
    • edit
      • [tests-only][full-ci] add test to check add, edit, rename & move activities for a file using file-id path #10312

  • Share: @prashant-gurung899

    • Created [full-ci][tests-only]add test for api activities after sharing a file #9795
    • Removed [full-ci][tests-only]add test for api activities after sharing a file #9795
    • Sharee actions (add/edit/delete) on the share - check activity by sharer [test-only][full-ci] add test to check sharee activities #9818
    • Link Created [test-only][full-ci] add test for api activities of a file after link creation and deletion #9803
    • Link Removed [test-only][full-ci] add test for api activities of a file after link creation and deletion #9803
    • Member Added [tests-only][full-ci] add test to check add and remove member acivities #9824
    • Member Removed [tests-only][full-ci] add test to check add and remove member acivities #9824
    • Public actions (add/edit/delete) on the share - check activity by sharer Activities. Wrong activity log when public changes file content #9676
      • [tests-only][full-ci] add tests to check activities after public actions #10201
    • share receiver can not see any activities, similar to versions (Activities. Sharee can get the shared file activities using the file-id #9849)

      if the user who makes the search request doesn't have the permission to see activities, early return with an error

      • [tests-only][full-ci] add test to check acivities by sharee #9842 response (403?)
    • update link share Activities. no activity for public link change (role, expiration date, password) #10012
      • [tests-only][full-ci] add tests to check activites of space after updating public share link #10160
    • update share [tests-only][full-ci] add tests to check activities of space's resource after updating it's share #10618
      • Activities. no activity for share change (role, expiration date) #10011
      • Activities. incorrect response for share change (permission role) #10228

• Activity filter: @Salipa-Gurung

  • depth (depth:-1) Activities. activity filter depth:-1 does not list activity #9850
    • [tests-only] [full-ci] Add test for default depth activity filter #10062
  • depth (depth:1) - for folder, should not list the activities for files inside that folder [tests-only] [full-ci] Test for activity filters #9861
  • limit (limit:2) [tests-only] [full-ci] Test for activity filters #9861
  • sort (asc| desc)
    • [tests-only][full-ci] add test to check api activities with sort filter #10235
  • limit with sort: Listing activities with limit doesn't handle sorting correctly #10150
    • [tests-only][full-ci] add test to check api activities with limit and sort filter #10234

• check activity message translation to the language other than English (Activities. activity lack language translation. #9856) @prashant-gurung899

  • [tests-only][full-ci] add test to check activity after language translation #9875
  • [tests-only][full-ci] adjust the activity language translation #9889

Bug Report:

• check activities for events (applicable to files, folders or spaces):

  • Resource (file/folder):
  • Activities. Resource id is missing in the old activities #9712

    • file version download Activities. no event for downloading file version #10008

    • restore deleted file Activities. no event for restoring file #10010

    • activities of destination file and folder [QA] Test coverage for activites api #9543 (comment)

      • copy zero byte file Activity. No activity for copying a zero byte file #10417

    • activities using file-id

      • add
      • copy zero byte file(destination file and folder) Activity. No activity for copying a zero byte file #10417
      • delete Activity. no event for deleting a file using file-id #10328

• Activity filter:

  • limit (limit:0, limit:-1) Activities. activity filter limit:0 and limit:-1 has confusing behaviour #9880

• Check activity without itemid filter Query the activity endpoint without an itemid filter doesn't return any results #10153

[saw-jan]

Bug reports:

• Activities. Wrong activity log when public changes file content #9676

[saw-jan]

Scenarios to test for COPY/MOVE actions:

• copy/move file (having some content) inside a folder

  • check activities of the destination file
  • check activities of the destination folder

• copy/move file (0 byte) inside a folder

  • check activities of the destination file
  • check activities of the destination folder

• copy/move file (some content and 0 byte) inside a folder by renaming the destination file

  • check activities of the destination file
  • check activities of the destination folder

• copy file (some content and 0 byte) into same folder by renaming the destination file

  • check activities of the destination file

[prashant-gurung899]

Scenarios to test for COPY/MOVE actions:

• copy/move file (having some content) inside a folder

  • check activities of the destination file

For this particular MOVE scenario, tests are already covered by :

Scenario: check move activity
Scenario: check move activity for a file and a folder

For other MOVE scenarios, tests are covered in PR: #10407 and #10409

And I'm currently working on COPY scenarios.
CC @saw-jan

[prashant-gurung899]

@saw-jan There are few cases where we dont get the copy response or no response at all. Please go through the following:

COPY (without using file-id)

copy file (having some content) inside a folder

check activities of the destination file
    > full response
check activities of the destination folder
    > full response

copy file (0 byte) inside a folder

check activities of the destination file
    > blank response --> {"value":[]}
check activities of the destination folder 
    >  no copy response. only folder creation response.

copy file (some content and 0 byte) inside a folder by renaming the destination file

file with content
check activities of the destination file 
    > only file added response for "renamed.txt". No previous history.
check activities of the destination folder 
    > full response

zero byte file
check activities of the destination file
    > blank response --> {"value":[]}
check activities of the destination folder
   > only folder creation response. no copy response

copy file (some content and 0 byte) into same folder by renaming the destination file

file with content
check activities of the destination file 
    > only file added response for "renamed.txt". No previous history.

zero byte file
check activities of the destination file
    > blank response --> {"value":[]}

[prashant-gurung899]

I have made a new issue to report a bug related to copying zero byte file:
#10417
cc @saw-jan

[prashant-gurung899]

COPY (without using file-id)

Test cases for COPY activities are covered in this PR: #10485
For zero byte files, see :#9543 (comment)

[prashant-gurung899]

@saw-jan Similarly for copying file using file-id, the zero byte file have no response at all. I have already created a bug report for that. See: #9543 (comment). For other suitable cases, i will write tests in next PR ASAP.

Please go through the following:

COPY (using file-id)

copy file (having some content) inside a folder

check activities of the destination file
    > full response
check activities of the destination folder
    > full response

copy file (0 byte) inside a folder

check activities of the destination file
    > blank response --> {"value":[]}
check activities of the destination folder 
    >  no copy response. only folder creation response.

copy file (some content and 0 byte) inside a folder by renaming the destination file

file with content
check activities of the destination file 
    > only file added response for "renamed.txt". No previous history.
check activities of the destination folder 
    > full response

zero byte file
check activities of the destination file
    > blank response --> {"value":[]}
check activities of the destination folder
   > only folder creation response. no copy response

copy file (some content and 0 byte) into same folder by renaming the destination file

file with content
check activities of the destination file 
    > only file added response for "renamed.txt". No previous history.

zero byte file
check activities of the destination file
    > blank response --> {"value":[]}

[prashant-gurung899]

COPY (using file-id)

Test cases for COPY activities using file-id are covered in this PR: #10534
For zero byte files, see :#9543 (comment)