Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] add test to check api activities with sort filter #10235

Merged
merged 1 commit into from
Oct 7, 2024
Merged

[tests-only][full-ci] add test to check api activities with sort filter #10235

merged 1 commit into from
Oct 7, 2024

Conversation

prashant-gurung899
Copy link
Contributor

Description

This PR adds tests to check api activities with sort filter (ascending and descending).

Scenario: check activity with sort filter

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 self-assigned this Oct 4, 2024
@prashant-gurung899 prashant-gurung899 mentioned this pull request Oct 4, 2024
Open
53 tasks
@prashant-gurung899 prashant-gurung899 marked this pull request as ready for review October 4, 2024 07:09
@prashant-gurung899 prashant-gurung899 force-pushed the tests-sort-filter-activities branch from a1bc406 to 08c5f44 Compare October 4, 2024 10:07
saw-jan
saw-jan requested changes Oct 7, 2024
View reviewed changes
tests/acceptance/TestHelpers/GraphHelper.php Outdated Show resolved Hide resolved
tests/acceptance/bootstrap/GraphContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/apiActivities/activities.feature Outdated Show resolved Hide resolved
@prashant-gurung899 prashant-gurung899 force-pushed the tests-sort-filter-activities branch from 08c5f44 to 960d77a Compare October 7, 2024 04:02
@saw-jan saw-jan mentioned this pull request Oct 7, 2024
Merged
9 tasks
@prashant-gurung899 prashant-gurung899 force-pushed the tests-sort-filter-activities branch 3 times, most recently from 28528db to a38a93b Compare October 7, 2024 06:24
@prashant-gurung899 prashant-gurung899 force-pushed the tests-sort-filter-activities branch from a38a93b to cff27a0 Compare October 7, 2024 07:10
@prashant-gurung899 prashant-gurung899 force-pushed the tests-sort-filter-activities branch 2 times, most recently from 408401b to 2dffff1 Compare October 7, 2024 08:44
@prashant-gurung899 prashant-gurung899 force-pushed the tests-sort-filter-activities branch from 2dffff1 to 8f858da Compare October 7, 2024 08:55
saw-jan
saw-jan approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✨

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 17c70a9 into master Oct 7, 2024
4 checks passed
@saw-jan saw-jan deleted the tests-sort-filter-activities branch October 7, 2024 09:45
ownclouders pushed a commit that referenced this pull request Oct 7, 2024
@saw-jan
Merge pull request #10235 from owncloud/tests-sort-filter-activities
4bebdd4 
[tests-only][full-ci] add test to check api activities with sort filter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@ishabaral ishabaral Awaiting requested review from ishabaral

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@prashant-gurung899 prashant-gurung899

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prashant-gurung899 @saw-jan