Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] add tests to check activities of space's resource after updating it's share #10618

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

prashant-gurung899
Copy link
Contributor

Description

This PR adds test to check activities of a space's resource after updating it's share with permission and expiration date.

Scenario: check share activities of a project space

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@prashant-gurung899 prashant-gurung899 force-pushed the tests-change-share-activities branch from 9e2535c to 911b484 Compare November 26, 2024 09:34
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best if this confusion clear before merging this PR https://github.com/owncloud/ocis/pull/10618/files#r1858175502

@saw-jan
Copy link
Member

saw-jan commented Nov 26, 2024

best if this confusion clear before merging this PR https://github.com/owncloud/ocis/pull/10618/files#r1858175502

You can rename the step like:

@Given user :user has updated the last resource share with the following properties:
@When user :user updates the last resource share with the following properties using the Graph API:

@prashant-gurung899 prashant-gurung899 force-pushed the tests-change-share-activities branch 3 times, most recently from df40fa5 to 9b41eca Compare November 27, 2024 05:53
@prashant-gurung899 prashant-gurung899 force-pushed the tests-change-share-activities branch from 91dbb66 to 5475f6c Compare November 27, 2024 07:18
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@saw-jan saw-jan merged commit fdff682 into master Nov 27, 2024
4 checks passed
@saw-jan saw-jan deleted the tests-change-share-activities branch November 27, 2024 08:16
ownclouders pushed a commit that referenced this pull request Nov 27, 2024
[tests-only][full-ci] add tests to check activities of space's resource after updating it's share
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants