Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] add test to check add and remove member acivities #9824

Merged
merged 1 commit into from
Aug 19, 2024
Merged

[tests-only][full-ci] add test to check add and remove member acivities #9824

merged 1 commit into from
Aug 19, 2024

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Aug 16, 2024 •
edited
Loading

Description

This PR adds test where a sharer checks api activities of a space after a member is added and removed.

Scenario: check add member to space activity
Scenario: check remove member from space activity

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 self-assigned this Aug 16, 2024
@prashant-gurung899 prashant-gurung899 mentioned this pull request Aug 16, 2024
Open
53 tasks
@prashant-gurung899 prashant-gurung899 marked this pull request as ready for review August 16, 2024 07:02
saw-jan
saw-jan reviewed Aug 19, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Please, rebase and resolve the conflicts

@prashant-gurung899
add test to check member acivities
ffe5710 
Signed-off-by: prashant-gurung899 <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@saw-jan saw-jan merged commit eac382a into master Aug 19, 2024
4 checks passed
@saw-jan saw-jan deleted the api-activities-member branch August 19, 2024 11:24
ownclouders pushed a commit that referenced this pull request Aug 19, 2024
@saw-jan
Merge pull request #9824 from owncloud/api-activities-member
15c1267 
[tests-only][full-ci] add test to check add and remove member acivities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@ishabaral ishabaral Awaiting requested review from ishabaral

@SagarGi SagarGi Awaiting requested review from SagarGi

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@prashant-gurung899 prashant-gurung899

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prashant-gurung899 @saw-jan