Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1400: Rebase to v1.22.0 for OCP 4.15 #232

Closed
wants to merge 123 commits into from

Conversation

mpatlasov
Copy link

Diff to upstream v1.22.0:
kubernetes-sigs/aws-ebs-csi-driver@v1.22.0...mpatlasov:rebase-v1.22.0

Notable changes since v1.18.0 (OCP 4.14):

  • Enable leader election in csi-resizer sidecar (#1606, @rdpsin)
  • Namespace-scoped leases permissions (#1614, @torredil)
  • Add additionalArgs parameter for sidecars (#1627, @ConnorJC3)
  • Fix context handling in WaitForVolumeAttachment & add in-flight checks to attachment/detachment operations (#1621, @torredil)
  • Extend resource list in Kustomization file (#1634, @torredil)
  • Add support for annotation-based volume modification via volume-modifier-for-k8s sidecar (#1600, @rdpsin)
  • Add startup taint removal feature (#1588, @ConnorJC3 and @gtxu)

Full changelog: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG.md

@openshift/storage

petderek and others added 30 commits April 14, 2023 21:02
Signed-off-by: Connor Catlett <[email protected]>
Use K8s `stable-1.27` for External Storage tests on Windows
…roughput

Allow throughput with defaulted GP3 volume type
Fix e2e test flakes due to volume node affinity conflict
Signed-off-by: Hanyue Liang <[email protected]>
Co-authored-by: Gengtao Xu <[email protected]>
Signed-off-by: Connor Catlett <[email protected]>
…release-url

Use dl.k8s.io instead of kubernetes-release bucket
NodeUnstage/UnpublishVolume should return a success when the path
requested has already been unstaged/unpublished.

Signed-off-by: Connor Catlett <[email protected]>
Signed-off-by: Eddie Torres <[email protected]>
The AWS SDK has its own EC2 interface, so ours is just bloatware
unnecessarily increasing developer overhead every time they forget to
add a function to it.

Signed-off-by: Connor Catlett <[email protected]>
Check for 'not mounted' in linux Unstage/Unpublish
Remove CPU limits; Decrease node pod CPU usage
The commit allows users to modify volume properties through PVC
annotations. For more details, refer to the modify-volume doc.
* Migrates Windows containers to EKS-D base images
* Add explicit runAsUserName to Windows manifests

Signed-off-by: Connor Catlett <[email protected]>
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 23, 2023
@openshift-ci-robot
Copy link

@mpatlasov: This pull request references Jira Issue OCPBUGS-16491, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @radeore

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Diff to upstream v1.22.0:
kubernetes-sigs/aws-ebs-csi-driver@v1.22.0...mpatlasov:rebase-v1.22.0

Notable changes since v1.18.0 (OCP 4.14):

  • Enable leader election in csi-resizer sidecar (#1606, @rdpsin)
  • Namespace-scoped leases permissions (#1614, @torredil)
  • Add additionalArgs parameter for sidecars (#1627, @ConnorJC3)
  • Fix context handling in WaitForVolumeAttachment & add in-flight checks to attachment/detachment operations (#1621, @torredil)
  • Extend resource list in Kustomization file (#1634, @torredil)
  • Add support for annotation-based volume modification via volume-modifier-for-k8s sidecar (#1600, @rdpsin)
  • Add startup taint removal feature (#1588, @ConnorJC3 and @gtxu)

Full changelog: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from radeore August 23, 2023 05:12
@mpatlasov
Copy link
Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Aug 23, 2023
@openshift-ci openshift-ci bot requested review from gnufied and jsafrane August 23, 2023 05:13
@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Aug 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@jsafrane
Copy link

/override ci/prow/verify-commits
I'm afraid we will need to do it manually for rebases.

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2023

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/verify-commits

In response to this:

/override ci/prow/verify-commits
I'm afraid we will need to do it manually for rebases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Aug 23, 2023

@mpatlasov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link

We need to discuss is we're going to support these two features and how. They may require change in our operators.

I added a topic to the next design meeting. @mpatlasov can you please check what they do?

@mpatlasov
Copy link
Author

/hold
(bump to 1.22 would be too dangerous at this time of 4.14 development)

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2023
@mpatlasov mpatlasov changed the title OCPBUGS-16491: to v1.22.0 for OCP 4.14 OCPBUGS-16491: Rebase to v1.22.0 for OCP 4.14 Aug 24, 2023
@mpatlasov mpatlasov changed the title OCPBUGS-16491: Rebase to v1.22.0 for OCP 4.14 STOR-1400: Rebase to v1.22.0 for OCP 4.14 Aug 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 25, 2023

@mpatlasov: This pull request references STOR-1400 which is a valid jira issue.

In response to this:

Diff to upstream v1.22.0:
kubernetes-sigs/aws-ebs-csi-driver@v1.22.0...mpatlasov:rebase-v1.22.0

Notable changes since v1.18.0 (OCP 4.14):

  • Enable leader election in csi-resizer sidecar (#1606, @rdpsin)
  • Namespace-scoped leases permissions (#1614, @torredil)
  • Add additionalArgs parameter for sidecars (#1627, @ConnorJC3)
  • Fix context handling in WaitForVolumeAttachment & add in-flight checks to attachment/detachment operations (#1621, @torredil)
  • Extend resource list in Kustomization file (#1634, @torredil)
  • Add support for annotation-based volume modification via volume-modifier-for-k8s sidecar (#1600, @rdpsin)
  • Add startup taint removal feature (#1588, @ConnorJC3 and @gtxu)

Full changelog: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/CHANGELOG.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 25, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 25, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpatlasov mpatlasov changed the title STOR-1400: Rebase to v1.22.0 for OCP 4.14 STOR-1400: Rebase to v1.22.0 for OCP 4.15 Aug 25, 2023
@jsafrane
Copy link

/close
Replaced by #244
(sorry, we had to rebase and then I picked v1.25.0)

@openshift-ci openshift-ci bot closed this Nov 21, 2023
Copy link

openshift-ci bot commented Nov 21, 2023

@jsafrane: Closed this PR.

In response to this:

/close
Replaced by #244
(sorry, we had to rebase and then I picked v1.25.0)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.