Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hanyuel to OWNERS #1587

Merged
merged 1 commit into from
May 3, 2023
Merged

Add hanyuel to OWNERS #1587

merged 1 commit into from
May 3, 2023

Conversation

hanyuel
Copy link
Contributor

@hanyuel hanyuel commented May 3, 2023

Add self to OWNERS.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 3, 2023
@k8s-ci-robot k8s-ci-robot requested review from gtxu and rdpsin May 3, 2023 14:20
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 3, 2023
@hanyuel hanyuel force-pushed the add-owner branch 2 times, most recently from 1a90ac3 to 762f0f7 Compare May 3, 2023 14:23
@rdpsin
Copy link
Contributor

rdpsin commented May 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@hanyuel hanyuel changed the title Add @hanyuel to OWNERS Add hanyuel to OWNERS May 3, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 3, 2023
torredil
torredil approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@torredil
Copy link
Member

torredil commented May 3, 2023

/retest

@hanyuel
Add hanyuel to OWNERS
f788016 
Signed-off-by: Hanyue Liang <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@torredil
Copy link
Member

torredil commented May 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 3, 2023 •
edited
Loading

@hanyuel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-ebs-csi-driver-test-e2e-external-eks-windows f788016 link false /test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@torredil
Copy link
Member

torredil commented May 3, 2023

/test pull-aws-ebs-csi-driver-test-e2e-external-eks-windows

@torredil
Copy link
Member

torredil commented May 3, 2023

/test pull-aws-ebs-csi-driver-e2e-single-az

@k8s-ci-robot k8s-ci-robot merged commit b57d85d into kubernetes-sigs:master May 3, 2023
@hanyuel hanyuel mentioned this pull request May 8, 2023
Merged
@hanyuel hanyuel deleted the add-owner branch June 30, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@gtxu gtxu Awaiting requested review from gtxu

@rdpsin rdpsin Awaiting requested review from rdpsin

Assignees

@rdpsin rdpsin

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanyuel @rdpsin @k8s-ci-robot @torredil