Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow throughput with defaulted GP3 volume type #1584

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Allow throughput with defaulted GP3 volume type #1584

merged 1 commit into from
Apr 24, 2023

Conversation

ConnorJC3
Copy link
Contributor

Fixes #1583 and adds a test case for the scenario

@k8s-ci-robot k8s-ci-robot requested review from rdpsin and torredil April 21, 2023 16:55
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 21, 2023
@rdpsin
Copy link
Contributor

rdpsin commented Apr 21, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2023
torredil
torredil reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this check createType == VolumeTypeGP3 necessary?

pkg/cloud/cloud.go Outdated Show resolved Hide resolved
@ConnorJC3 ConnorJC3 force-pushed the fix-default-throughput branch from f408aae to d553224 Compare April 21, 2023 17:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2023
@ConnorJC3 ConnorJC3 force-pushed the fix-default-throughput branch from d553224 to 88db58c Compare April 21, 2023 17:13
torredil
torredil approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2023
@torredil
Copy link
Member

/retest

@ConnorJC3
Copy link
Contributor Author

/check-cla

@gtxu
Copy link
Contributor

gtxu commented Apr 21, 2023

/lgtm

@gtxu
Copy link
Contributor

gtxu commented Apr 21, 2023

/retest

@k8s-ci-robot
Copy link
Contributor

@hanyuel: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gtxu
Copy link
Contributor

gtxu commented Apr 21, 2023

/retest

@torredil
Copy link
Member

/test pull-aws-ebs-csi-driver-external-test-eks

2 similar comments
@torredil
Copy link
Member

/test pull-aws-ebs-csi-driver-external-test-eks

@torredil
Copy link
Member

/test pull-aws-ebs-csi-driver-external-test-eks

@k8s-ci-robot k8s-ci-robot merged commit aaeddc0 into kubernetes-sigs:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyuel hanyuel hanyuel approved these changes

@torredil torredil torredil approved these changes

@rdpsin rdpsin Awaiting requested review from rdpsin

Assignees

@rdpsin rdpsin

@gtxu gtxu

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throughput parameter doesn't work
6 participants
@ConnorJC3 @rdpsin @k8s-ci-robot @torredil @gtxu @hanyuel