-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase external test pod start timeout #1586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eddie Torres <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
May 3, 2023
k8s-ci-robot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
May 3, 2023
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
May 3, 2023
hanyuel
approved these changes
May 3, 2023
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rdpsin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
May 3, 2023
torredil
added a commit
to torredil/aws-ebs-csi-driver
that referenced
this pull request
May 25, 2023
Signed-off-by: Eddie Torres <[email protected]>
k8s-ci-robot
added a commit
that referenced
this pull request
Jun 5, 2023
Revert Increase external test pod start timeout #1586
ConnorJC3
added a commit
to ConnorJC3/aws-ebs-csi-driver
that referenced
this pull request
Jun 16, 2023
ConnorJC3
added a commit
to ConnorJC3/aws-ebs-csi-driver
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about? / Why do we need it?
Recently, our CI has been consistently failing due to testing pods taking longer than 5 minutes (default) to transition into a running state. See #1578 as an example.
This PR increases the pod start timeout when running the external storage tests by modifying the DriverDefinition
Timeouts.PodStart
parameter:What testing is done?