Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase external test pod start timeout #1586

Merged
merged 1 commit into from
May 3, 2023

Conversation

torredil
Copy link
Member

@torredil torredil commented May 3, 2023

What is this PR about? / Why do we need it?

Recently, our CI has been consistently failing due to testing pods taking longer than 5 minutes (default) to transition into a running state. See #1578 as an example.

This PR increases the pod start timeout when running the external storage tests by modifying the DriverDefinitionTimeouts.PodStart parameter:

// Timeouts contains the custom timeouts used during the test execution.
// The values specified here will override the default values specified in
// the framework.TimeoutContext struct.
Timeouts map[string]string

What testing is done?

  • CI
  • Stress testing
  StressTestOptions:
    NumPods: 10
    NumRestarts: 10
kubetest2 noop \                                                                          
  --run-id="e2e-kubernetes" \
  --test=ginkgo \
  -- \
  --test-package-version=v1.27.0-alpha.3 \
  --skip-regex="\[Disruptive\]" \
  --focus-regex="\bebs.csi.aws.com\b.*multiple pods should access different volumes repeatedly" \
  --parallel=15 \
  --test-args="-storage.testdriver=manifests.yaml"

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2023
@k8s-ci-robot k8s-ci-robot requested review from gtxu and rdpsin May 3, 2023 13:34
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 3, 2023
@rdpsin
Copy link
Contributor

rdpsin commented May 3, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@torredil torredil requested review from ConnorJC3 and hanyuel May 3, 2023 14:34
@rdpsin
Copy link
Contributor

rdpsin commented May 3, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rdpsin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0d764ba into kubernetes-sigs:master May 3, 2023
torredil added a commit to torredil/aws-ebs-csi-driver that referenced this pull request May 25, 2023
k8s-ci-robot added a commit that referenced this pull request Jun 5, 2023
Revert Increase external test pod start timeout #1586
ConnorJC3 added a commit to ConnorJC3/aws-ebs-csi-driver that referenced this pull request Jun 16, 2023
ConnorJC3 added a commit to ConnorJC3/aws-ebs-csi-driver that referenced this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants