Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Rules UI/UX improvements #585

Closed
jovancacvetkovic opened this issue May 17, 2023 · 0 comments · Fixed by #592
Closed

[FEATURE] Rules UI/UX improvements #585

jovancacvetkovic opened this issue May 17, 2023 · 0 comments · Fixed by #592
Labels
enhancement New feature or request untriaged

Comments

@jovancacvetkovic
Copy link

Is your feature request related to a problem?
Add the rules UI/UX improvements:

  • Page heading should read the "Create detection rule"
  • Remove the line under the "Create detection rule" heading
  • Breadcrumbs should read: Security Analytics > Detection rules > Create detection rule
  • Title of the table should read "Detection rules"
  • Make sure that sidebar reads "Detection rules"

Do you have any additional context?
Screenshot from 2023-05-17 16-41-52
image
@jovancacvetkovic jovancacvetkovic added enhancement New feature or request untriaged labels May 17, 2023
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue May 19, 2023
@jovancvetkovic3006
[FEATURE] Rules UI/UX improvements opensearch-project#585
a8cd869 
Signed-off-by: Jovan Cvetkovic <[email protected]>
@jovancacvetkovic jovancacvetkovic mentioned this issue May 19, 2023
Merged
1 task
AWSHurneyt pushed a commit that referenced this issue May 30, 2023
@jovancvetkovic3006
[FEATURE] Rules UI/UX improvements (#592)
1f8105d 
* [FEATURE] Rules UI/UX improvements #585

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detection rules page | Filter name typo #588

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
amsiglan pushed a commit to amsiglan/security-analytics-dashboards-plugin that referenced this issue May 30, 2023
@jovancvetkovic3006 @amsiglan
[FEATURE] Rules UI/UX improvements (opensearch-project#592)
b9367d1 
* [FEATURE] Rules UI/UX improvements opensearch-project#585

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detection rules page | Filter name typo opensearch-project#588

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
amsiglan pushed a commit to amsiglan/security-analytics-dashboards-plugin that referenced this issue May 30, 2023
@jovancvetkovic3006 @amsiglan
[FEATURE] Rules UI/UX improvements (opensearch-project#592)
986cc7d 
* [FEATURE] Rules UI/UX improvements opensearch-project#585

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detection rules page | Filter name typo opensearch-project#588

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit that referenced this issue May 30, 2023
@amsiglan @jovancvetkovic3006
[FEATURE] Rules UI/UX improvements (#592) (#609)
911b5bc 
* [FEATURE] Rules UI/UX improvements #585



* [BUG] Detection rules page | Filter name typo #588



* Code review



---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit that referenced this issue May 30, 2023
@amsiglan @opensearch-trigger-bot @jovancvetkovic3006
[Backport 2.8] PRs 575, 581, 592, 594 (#608)
37a440e 
* Detection rule new detection ux (#575) (#596)

* basic framework ready

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* working without validation

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* detection rule updates

Signed-off-by: Jovan Cvetkovic <[email protected]>

* detection rule updates

Signed-off-by: Jovan Cvetkovic <[email protected]>

* detection rule updates

Signed-off-by: Jovan Cvetkovic <[email protected]>

* added validation for duplicate keys; do not submit if detection has errors

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* validations added

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* more validations

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* comment update

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit feb0ed7)

Co-authored-by: Amardeepsingh Siglani <[email protected]>

* cypress tests update (#581)

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update selection panel component for the "Create detection rule" (#594)

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Rules UI/UX improvements (#592)

* [FEATURE] Rules UI/UX improvements #585

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detection rules page | Filter name typo #588

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
@amsiglan @jovancvetkovic3006 @AWSHurneyt
[FEATURE] Rules UI/UX improvements (opensearch-project#592) (opensear…
4ae39d9 
…ch-project#609)

* [FEATURE] Rules UI/UX improvements opensearch-project#585



* [BUG] Detection rules page | Filter name typo opensearch-project#588



* Code review



---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FEATURE] Rules UI/UX improvements jovancacvetkovic/security-analytics-dashboards-plugin
1 participant
@jovancacvetkovic