Detection rule new detection ux #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #575 +/- ##
==========================================
- Coverage 32.45% 31.47% -0.98%
==========================================
Files 137 138 +1
Lines 4126 4340 +214
Branches 677 723 +46
==========================================
+ Hits 1339 1366 +27
- Misses 2648 2835 +187
Partials 139 139 |
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
…rrors Signed-off-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt
approved these changes
May 5, 2023
public/pages/Rules/components/RuleEditor/DetectionVisualEditor.tsx
Outdated
Show resolved
Hide resolved
public/pages/Rules/components/RuleEditor/DetectionVisualEditor.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
eirsep
approved these changes
May 6, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 25, 2023
* basic framework ready Signed-off-by: Amardeepsingh Siglani <[email protected]> * working without validation Signed-off-by: Amardeepsingh Siglani <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * added validation for duplicate keys; do not submit if detection has errors Signed-off-by: Amardeepsingh Siglani <[email protected]> * validations added Signed-off-by: Amardeepsingh Siglani <[email protected]> * more validations Signed-off-by: Amardeepsingh Siglani <[email protected]> * comment update Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit feb0ed7)
amsiglan
added a commit
that referenced
this pull request
May 30, 2023
* basic framework ready Signed-off-by: Amardeepsingh Siglani <[email protected]> * working without validation Signed-off-by: Amardeepsingh Siglani <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * added validation for duplicate keys; do not submit if detection has errors Signed-off-by: Amardeepsingh Siglani <[email protected]> * validations added Signed-off-by: Amardeepsingh Siglani <[email protected]> * more validations Signed-off-by: Amardeepsingh Siglani <[email protected]> * comment update Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit feb0ed7) Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan
added a commit
to amsiglan/security-analytics-dashboards-plugin
that referenced
this pull request
May 30, 2023
…project#596) * basic framework ready Signed-off-by: Amardeepsingh Siglani <[email protected]> * working without validation Signed-off-by: Amardeepsingh Siglani <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * added validation for duplicate keys; do not submit if detection has errors Signed-off-by: Amardeepsingh Siglani <[email protected]> * validations added Signed-off-by: Amardeepsingh Siglani <[email protected]> * more validations Signed-off-by: Amardeepsingh Siglani <[email protected]> * comment update Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit feb0ed7) Co-authored-by: Amardeepsingh Siglani <[email protected]>
1 task
AWSHurneyt
pushed a commit
that referenced
this pull request
May 30, 2023
* Detection rule new detection ux (#575) (#596) * basic framework ready Signed-off-by: Amardeepsingh Siglani <[email protected]> * working without validation Signed-off-by: Amardeepsingh Siglani <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * added validation for duplicate keys; do not submit if detection has errors Signed-off-by: Amardeepsingh Siglani <[email protected]> * validations added Signed-off-by: Amardeepsingh Siglani <[email protected]> * more validations Signed-off-by: Amardeepsingh Siglani <[email protected]> * comment update Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit feb0ed7) Co-authored-by: Amardeepsingh Siglani <[email protected]> * cypress tests update (#581) Signed-off-by: Jovan Cvetkovic <[email protected]> * Update selection panel component for the "Create detection rule" (#594) * [FEATURE] Update selection panel component for the "Create detection rule" page #587 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Update selection panel component for the "Create detection rule" page #587 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Update selection panel component for the "Create detection rule" page #587 Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Update selection panel component for the "Create detection rule" page #587 Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> * [FEATURE] Rules UI/UX improvements (#592) * [FEATURE] Rules UI/UX improvements #585 Signed-off-by: Jovan Cvetkovic <[email protected]> * [BUG] Detection rules page | Filter name typo #588 Signed-off-by: Jovan Cvetkovic <[email protected]> * Code review Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/security-analytics-dashboards-plugin
that referenced
this pull request
Oct 12, 2023
…project#596) * basic framework ready Signed-off-by: Amardeepsingh Siglani <[email protected]> * working without validation Signed-off-by: Amardeepsingh Siglani <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * detection rule updates Signed-off-by: Jovan Cvetkovic <[email protected]> * added validation for duplicate keys; do not submit if detection has errors Signed-off-by: Amardeepsingh Siglani <[email protected]> * validations added Signed-off-by: Amardeepsingh Siglani <[email protected]> * more validations Signed-off-by: Amardeepsingh Siglani <[email protected]> * comment update Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> (cherry picked from commit feb0ed7) Co-authored-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced the detection code editor in Detection rule creation form to use UI components. It simplifies entering detection and also allows user to enter values for a field by uploading text or csv files.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.