Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Update selection panel component for the "Create detection rule" page #587

Closed
jovancacvetkovic opened this issue May 17, 2023 · 0 comments · Fixed by #594
Closed

[FEATURE] Update selection panel component for the "Create detection rule" page #587

jovancacvetkovic opened this issue May 17, 2023 · 0 comments · Fixed by #594
Labels
enhancement New feature or request untriaged

Comments

@jovancacvetkovic
Copy link

jovancacvetkovic commented May 17, 2023 •
edited
Loading

Is your feature request related to a problem?
Update the selection panel component for each selection in the "Create detection rule" page:

  • Set "selection_1", "selection_2", etc. as editable default for selection names
  • Fix spacing and horizontal rule under collapsed maps accordions
  • Remove restriction from the tag names
  • Set rule status to "experimental" as a default
  • The default color for the "trash can" button icon is OUItextsubdued, it changes to OUItextdanger on mouse over (no change in background color)

Do you have any additional context?
image
@jovancacvetkovic jovancacvetkovic added enhancement New feature or request untriaged labels May 17, 2023
@jovancacvetkovic jovancacvetkovic changed the title [FEATURE] Create a selection panel component for the "Create detection rule" page [FEATURE] Update selection panel component for the "Create detection rule" page May 22, 2023
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue May 22, 2023
@jovancvetkovic3006
[FEATURE] Update selection panel component for the "Create detection …
53c6447 
…rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue May 22, 2023
@jovancvetkovic3006
[FEATURE] Update selection panel component for the "Create detection …
961b594 
…rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue May 22, 2023
@jovancvetkovic3006
[FEATURE] Update selection panel component for the "Create detection …
7d3cb05 
…rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue May 22, 2023
@jovancvetkovic3006
[FEATURE] Update selection panel component for the "Create detection …
93c5238 
…rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>
@jovancacvetkovic jovancacvetkovic mentioned this issue May 24, 2023
Merged
1 task
AWSHurneyt pushed a commit that referenced this issue May 30, 2023
@jovancvetkovic3006
Update selection panel component for the "Create detection rule" (#594)
1373523 
* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
amsiglan pushed a commit to amsiglan/security-analytics-dashboards-plugin that referenced this issue May 30, 2023
@jovancvetkovic3006 @amsiglan
Update selection panel component for the "Create detection rule" (ope…
8f10d5c 
…nsearch-project#594)

* [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
amsiglan pushed a commit to amsiglan/security-analytics-dashboards-plugin that referenced this issue May 30, 2023
@jovancvetkovic3006 @amsiglan
Update selection panel component for the "Create detection rule" (ope…
df179e9 
…nsearch-project#594)

* [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
amsiglan added a commit that referenced this issue May 30, 2023
@amsiglan @jovancvetkovic3006
[Backport 2.x] Backporting #581 and #594 (#606)
b840da7 
* cypress tests update (#581)

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update selection panel component for the "Create detection rule" (#594)

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit that referenced this issue May 30, 2023
@amsiglan @opensearch-trigger-bot @jovancvetkovic3006
[Backport 2.8] PRs 575, 581, 592, 594 (#608)
37a440e 
* Detection rule new detection ux (#575) (#596)

* basic framework ready

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* working without validation

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* detection rule updates

Signed-off-by: Jovan Cvetkovic <[email protected]>

* detection rule updates

Signed-off-by: Jovan Cvetkovic <[email protected]>

* detection rule updates

Signed-off-by: Jovan Cvetkovic <[email protected]>

* added validation for duplicate keys; do not submit if detection has errors

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* validations added

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* more validations

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* comment update

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit feb0ed7)

Co-authored-by: Amardeepsingh Siglani <[email protected]>

* cypress tests update (#581)

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update selection panel component for the "Create detection rule" (#594)

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page #587

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Rules UI/UX improvements (#592)

* [FEATURE] Rules UI/UX improvements #585

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detection rules page | Filter name typo #588

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
@amsiglan @jovancvetkovic3006 @AWSHurneyt
[Backport 2.x] Backporting opensearch-project#581 and opensearch-proj…
2a03894 
…ect#594  (opensearch-project#606)

* cypress tests update (opensearch-project#581)

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Update selection panel component for the "Create detection rule" (opensearch-project#594)

* [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Update selection panel component for the "Create detection rule" page opensearch-project#587

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request untriaged
Projects
None yet
Milestone
No milestone
1 participant
@jovancacvetkovic