Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Rules UI/UX improvements (#592) #609

Merged
merged 1 commit into from
May 30, 2023

Conversation

amsiglan
Copy link
Collaborator

Description

Backport #592

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* [FEATURE] Rules UI/UX improvements opensearch-project#585

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Detection rules page | Filter name typo opensearch-project#588

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #609 (986cc7d) into 2.x (b840da7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x     #609   +/-   ##
=======================================
  Coverage   31.46%   31.46%           
=======================================
  Files         138      138           
  Lines        4335     4335           
  Branches      771      771           
=======================================
  Hits         1364     1364           
  Misses       2832     2832           
  Partials      139      139           

see 1 file with indirect coverage changes

@AWSHurneyt AWSHurneyt merged commit 911b5bc into opensearch-project:2.x May 30, 2023
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…ch-project#609)

* [FEATURE] Rules UI/UX improvements opensearch-project#585



* [BUG] Detection rules page | Filter name typo opensearch-project#588



* Code review



---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants