Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.9] Backport 1113 to 2.9 #1135

Closed

Conversation

ryanbogan
Copy link
Member

Description

Adds a check to skip remote inference integration tests if the API key is null

Backport of #1113

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ylwu-amzn and others added 27 commits July 10, 2023 19:55
…opensearch-project#1067)

* remote inference: add unit test for create connector request/response

Signed-off-by: Yaliang Wu <[email protected]>

* fix failed UT

Signed-off-by: Yaliang Wu <[email protected]>

* fix failed UT

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
…project#1068)

* fix cannot specify model access control parameters error

Signed-off-by: Yaliang Wu <[email protected]>

* add unit test for model group class and fix some bug

Signed-off-by: Yaliang Wu <[email protected]>

* fix failed ut

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
…ject#1074)

* PenTest fixes: error codes and update model group fix

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix get model assertion error

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
* Change connector access control creation allow empty list

Signed-off-by: zane-neo <[email protected]>

* Fix rare private ip address bypass SSRF issue

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
…rch-project#1078)

* modify error message when model group not unique is provided

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix unique model group name unit test

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
* init master key automatically

Signed-off-by: Yaliang Wu <[email protected]>

* remove unnecessary escape

Signed-off-by: Yaliang Wu <[email protected]>

* fix failed ut

Signed-off-by: Yaliang Wu <[email protected]>

* tune syncup jot interval

Signed-off-by: Yaliang Wu <[email protected]>

* tune syncup jot interval

Signed-off-by: Yaliang Wu <[email protected]>

* remove local config file code

Signed-off-by: Yaliang Wu <[email protected]>

* set master key when init remote model

Signed-off-by: Yaliang Wu <[email protected]>

* move init master key to encryptor

Signed-off-by: Yaliang Wu <[email protected]>

* fine tune code

Signed-off-by: Yaliang Wu <[email protected]>

* fine tune code

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
* IT Security Tests for model access control

Signed-off-by: Bhavana Ramaram <[email protected]>

* Fix assertion error

Signed-off-by: Bhavana Ramaram <[email protected]>

* Fix format violations

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
* Add test keys to CI related workflows

Signed-off-by: Peter Zhu <[email protected]>

* test more

Signed-off-by: Peter Zhu <[email protected]>

* more test

Signed-off-by: Peter Zhu <[email protected]>

* test

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
* 2.9 release notes

Signed-off-by: Bhavana Ramaram <[email protected]>

* move PR1065 from infrastructure to feature

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Bhavana Ramaram <[email protected]>
…oject#1073)

* Add remote inference integration tests for OpenAI and Cohere

Signed-off-by: Ryan Bogan <[email protected]>

* Change edits model test

Signed-off-by: Ryan Bogan <[email protected]>

* Change loop number in edits test

Signed-off-by: Ryan Bogan <[email protected]>

* Change edits model test again

Signed-off-by: Ryan Bogan <[email protected]>

* Fix spotless

Signed-off-by: Ryan Bogan <[email protected]>

* Refactoring

Signed-off-by: Ryan Bogan <[email protected]>

* Fix typo

Signed-off-by: Ryan Bogan <[email protected]>

* Remove env vars

Signed-off-by: Peter Zhu <[email protected]>

* Removing unnecessary comments

Signed-off-by: Ryan Bogan <[email protected]>

* Rebase with 2.x and remove set up for master key

Signed-off-by: Ryan Bogan <[email protected]>

* Remove print line

Signed-off-by: Ryan Bogan <[email protected]>

* Add throttling check

Signed-off-by: Ryan Bogan <[email protected]>

* Minor change for assert statement

Signed-off-by: Ryan Bogan <[email protected]>

* Test changes

Signed-off-by: Ryan Bogan <[email protected]>

* Uncomment delete connector test

Signed-off-by: Ryan Bogan <[email protected]>

---------

Signed-off-by: Ryan Bogan <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
@ryanbogan ryanbogan temporarily deployed to ml-commons-cicd-env July 17, 2023 17:52 — with GitHub Actions Inactive
@ryanbogan ryanbogan temporarily deployed to ml-commons-cicd-env July 17, 2023 17:52 — with GitHub Actions Inactive
@ryanbogan ryanbogan had a problem deploying to ml-commons-cicd-env July 17, 2023 17:52 — with GitHub Actions Failure
@ryanbogan ryanbogan temporarily deployed to ml-commons-cicd-env July 17, 2023 17:52 — with GitHub Actions Inactive
@ryanbogan ryanbogan closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants