Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null key check for remote inference integration tests #1113

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

ryanbogan
Copy link
Member

Description

Adds a check to skip remote inference integration tests if the API key is null

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ryanbogan ryanbogan temporarily deployed to ml-commons-cicd-env July 17, 2023 17:03 — with GitHub Actions Inactive
@ryanbogan ryanbogan temporarily deployed to ml-commons-cicd-env July 17, 2023 17:03 — with GitHub Actions Inactive
@ryanbogan ryanbogan temporarily deployed to ml-commons-cicd-env July 17, 2023 17:03 — with GitHub Actions Inactive
@ryanbogan ryanbogan temporarily deployed to ml-commons-cicd-env July 17, 2023 17:03 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #1113 (1ee582e) into 2.x (f672aa8) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #1113      +/-   ##
============================================
+ Coverage     78.95%   78.97%   +0.02%     
- Complexity     2119     2121       +2     
============================================
  Files           167      167              
  Lines          8633     8633              
  Branches        869      869              
============================================
+ Hits           6816     6818       +2     
+ Misses         1422     1420       -2     
  Partials        395      395              
Flag Coverage Δ
ml-commons 78.97% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@ylwu-amzn ylwu-amzn merged commit e17c7db into opensearch-project:2.x Jul 17, 2023
@ryanbogan ryanbogan deleted the change_integ_tests branch July 17, 2023 17:29
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 17, 2023
Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit e17c7db)
zane-neo pushed a commit to zane-neo/ml-commons that referenced this pull request Sep 1, 2023
zane-neo pushed a commit that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants