-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify error message when model group not unique is provided #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bhavana Ramaram <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>
dhrubo-os
approved these changes
Jul 12, 2023
ylwu-amzn
approved these changes
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #1078 +/- ##
============================================
+ Coverage 77.95% 78.75% +0.80%
- Complexity 2071 2100 +29
============================================
Files 167 167
Lines 8558 8568 +10
Branches 857 862 +5
============================================
+ Hits 6671 6748 +77
+ Misses 1503 1426 -77
- Partials 384 394 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
* modify error message when model group not unique is provided Signed-off-by: Bhavana Ramaram <[email protected]> * fix unique model group name unit test Signed-off-by: Bhavana Ramaram <[email protected]> --------- Signed-off-by: Bhavana Ramaram <[email protected]> (cherry picked from commit df2a0f5)
rbhavna
added a commit
that referenced
this pull request
Jul 12, 2023
…1088) * modify error message when model group not unique is provided Signed-off-by: Bhavana Ramaram <[email protected]> * fix unique model group name unit test Signed-off-by: Bhavana Ramaram <[email protected]> --------- Signed-off-by: Bhavana Ramaram <[email protected]> (cherry picked from commit df2a0f5) Co-authored-by: Bhavana Ramaram <[email protected]>
zane-neo
pushed a commit
to zane-neo/ml-commons
that referenced
this pull request
Sep 1, 2023
…rch-project#1078) * modify error message when model group not unique is provided Signed-off-by: Bhavana Ramaram <[email protected]> * fix unique model group name unit test Signed-off-by: Bhavana Ramaram <[email protected]> --------- Signed-off-by: Bhavana Ramaram <[email protected]>
zane-neo
pushed a commit
that referenced
this pull request
Sep 1, 2023
* modify error message when model group not unique is provided Signed-off-by: Bhavana Ramaram <[email protected]> * fix unique model group name unit test Signed-off-by: Bhavana Ramaram <[email protected]> --------- Signed-off-by: Bhavana Ramaram <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modify error message when model group not unique is provided
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.