remote inference: add unit test for create connector request/response #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Yaliang Wu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #1067 +/- ##
=========================================
Coverage 77.34% 77.34%
Complexity 2054 2054
=========================================
Files 167 167
Lines 8532 8532
Branches 846 846
=========================================
Hits 6599 6599
Misses 1555 1555
Partials 378 378
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Yaliang Wu <[email protected]>
zane-neo
reviewed
Jul 11, 2023
| @@ -133,12 +149,15 @@ public static MLCreateConnectorInput parse(XContentParser parser) throws IOExcep | |||
| case ACCESS_MODE_FIELD: | |||
| access = AccessMode.from(parser.text()); | |||
| break; | |||
| case DRY_RUN_FIELD: | |||
| dryRun = parser.booleanValue(); | |||
There was a problem hiding this comment.
dryRun is mandatory in request?
There was a problem hiding this comment.
not mandatory, its default value is false, so it's ok to not use optional method.
zane-neo
approved these changes
Jul 11, 2023
b4sjoo
approved these changes
Jul 11, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
…#1067) * remote inference: add unit test for create connector request/response Signed-off-by: Yaliang Wu <[email protected]> * fix failed UT Signed-off-by: Yaliang Wu <[email protected]> * fix failed UT Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 1602aea)
rbhavna
pushed a commit
that referenced
this pull request
Jul 12, 2023
…#1067) (#1082) * remote inference: add unit test for create connector request/response Signed-off-by: Yaliang Wu <[email protected]> * fix failed UT Signed-off-by: Yaliang Wu <[email protected]> * fix failed UT Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 1602aea) Co-authored-by: Yaliang Wu <[email protected]>
zane-neo
pushed a commit
to zane-neo/ml-commons
that referenced
this pull request
Sep 1, 2023
…opensearch-project#1067) * remote inference: add unit test for create connector request/response Signed-off-by: Yaliang Wu <[email protected]> * fix failed UT Signed-off-by: Yaliang Wu <[email protected]> * fix failed UT Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]>
zane-neo
pushed a commit
that referenced
this pull request
Sep 1, 2023
…#1067) * remote inference: add unit test for create connector request/response Signed-off-by: Yaliang Wu <[email protected]> * fix failed UT Signed-off-by: Yaliang Wu <[email protected]> * fix failed UT Signed-off-by: Yaliang Wu <[email protected]> --------- Signed-off-by: Yaliang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.