-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Backport query assist #1369
[2.x] Backport query assist #1369
Conversation
…ature/explorer-query-assistant Merge feature/explorer-query-assistant to main (cherry picked from commit 38957cd)
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 7b4d148)
* turned 40 year defaults into dependent on query assistant Signed-off-by: Paul Sebastian <[email protected]> * fix search test, undefined handling Signed-off-by: Paul Sebastian <[email protected]> * include some constants for specific time choices Signed-off-by: Paul Sebastian <[email protected]> * changed naming of some constants Signed-off-by: Paul Sebastian <[email protected]> * fix search test Signed-off-by: Paul Sebastian <[email protected]> * change back query slice Signed-off-by: Paul Sebastian <[email protected]> * failing snapshot updated after merge with main Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]> (cherry picked from commit d741ed4)
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit a5824bd)
Thanks for taking this on @joshuali925. LGTM, and just a tiny linting error need to be fixed: https://github.com/opensearch-project/dashboards-observability/actions/runs/7588601129/job/20671492177?pr=1369#step:10:95 |
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit fa8e856)
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 4cfd171)
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 2b6a9da)
@RyanL1997 i just realized that current lint workflow will fail if one file failed to lint, it gets tedious if there are multiple failed files since it requires multiple runs i sent a PR to fix it #1378 |
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 1c76442)
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit f2dcae4)
Signed-off-by: Joshua Li <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> (cherry picked from commit d4d8dbc)
Description
backports #1325, #1359, #1360, #1376, #1379
cc @paulstn i picked the 3 commits for query assist to 2.x, if you have other fixes for it please let me know or update this PR
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.