Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Backport query assist #1369

Merged
merged 14 commits into from
Jan 23, 2024

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Jan 18, 2024

Description

backports #1325, #1359, #1360, #1376, #1379

cc @paulstn i picked the 3 commits for query assist to 2.x, if you have other fixes for it please let me know or update this PR

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

paulstn and others added 3 commits January 18, 2024 01:03
…ature/explorer-query-assistant

Merge feature/explorer-query-assistant to main

(cherry picked from commit 38957cd)
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 7b4d148)
* turned 40 year defaults into dependent on query assistant

Signed-off-by: Paul Sebastian <[email protected]>

* fix search test, undefined handling

Signed-off-by: Paul Sebastian <[email protected]>

* include some constants for specific time choices

Signed-off-by: Paul Sebastian <[email protected]>

* changed naming of some constants

Signed-off-by: Paul Sebastian <[email protected]>

* fix search test

Signed-off-by: Paul Sebastian <[email protected]>

* change back query slice

Signed-off-by: Paul Sebastian <[email protected]>

* failing snapshot updated after merge with main

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
(cherry picked from commit d741ed4)
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Comparison is base (d9bd287) 52.90% compared to head (928981e) 53.37%.

Files Patch % Lines
public/components/common/search/search.tsx 41.41% 58 Missing ⚠️
...ts/event_analytics/explorer/query_assist/input.tsx 74.72% 22 Missing and 1 partial ⚠️
public/components/common/search/query_area.tsx 0.00% 17 Missing ⚠️
...vent_analytics/explorer/events_views/data_grid.tsx 40.74% 16 Missing ⚠️
...mponents/event_analytics/hooks/use_fetch_events.ts 5.88% 16 Missing ⚠️
...nents/common/search/query_assist_summarization.tsx 0.00% 10 Missing ⚠️
...components/event_analytics/explorer/no_results.tsx 37.50% 4 Missing and 1 partial ⚠️
...onents/event_analytics/hooks/use_fetch_patterns.ts 0.00% 3 Missing ⚠️
public/components/common/search/date_picker.tsx 71.42% 1 Missing and 1 partial ⚠️
.../event_analytics/hooks/use_fetch_visualizations.ts 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1369      +/-   ##
==========================================
+ Coverage   52.90%   53.37%   +0.47%     
==========================================
  Files         302      310       +8     
  Lines       10594    10920     +326     
  Branches     2777     2865      +88     
==========================================
+ Hits         5605     5829     +224     
- Misses       4944     5043      +99     
- Partials       45       48       +3     
Flag Coverage Δ
dashboards-observability 53.37% <62.13%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

public/plugin.ts Show resolved Hide resolved
Signed-off-by: Joshua Li <[email protected]>
@joshuali925 joshuali925 added the enhancement New feature or request label Jan 18, 2024
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit a5824bd)
@RyanL1997
Copy link
Collaborator

Thanks for taking this on @joshuali925. LGTM, and just a tiny linting error need to be fixed: https://github.com/opensearch-project/dashboards-observability/actions/runs/7588601129/job/20671492177?pr=1369#step:10:95

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit fa8e856)
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 4cfd171)
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 2b6a9da)
@joshuali925
Copy link
Member Author

@RyanL1997 i just realized that current lint workflow will fail if one file failed to lint, it gets tedious if there are multiple failed files since it requires multiple runs

i sent a PR to fix it #1378

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 1c76442)
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
@joshuali925 joshuali925 merged commit d4d8dbc into opensearch-project:2.x Jan 23, 2024
12 of 19 checks passed
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Paul Sebastian <[email protected]>
(cherry picked from commit d4d8dbc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants