-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test failures from query assistant #1360
Merged
paulstn
merged 9 commits into
opensearch-project:main
from
paulstn:feature-explorer-query-assistant
Jan 16, 2024
Merged
Fix test failures from query assistant #1360
paulstn
merged 9 commits into
opensearch-project:main
from
paulstn:feature-explorer-query-assistant
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
…/paulstn/dashboards-observability into feature-explorer-query-assistant
Signed-off-by: Paul Sebastian <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1360 +/- ##
==========================================
+ Coverage 52.92% 53.06% +0.14%
==========================================
Files 302 312 +10
Lines 10587 11115 +528
Branches 2777 2899 +122
==========================================
+ Hits 5603 5898 +295
- Misses 4939 5169 +230
- Partials 45 48 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joshuali925
reviewed
Jan 12, 2024
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Swiddis
approved these changes
Jan 16, 2024
joshuali925
approved these changes
Jan 16, 2024
Signed-off-by: Paul Sebastian <[email protected]>
6 tasks
paulstn
added a commit
to paulstn/dashboards-observability
that referenced
this pull request
Jan 22, 2024
* turned 40 year defaults into dependent on query assistant Signed-off-by: Paul Sebastian <[email protected]> * fix search test, undefined handling Signed-off-by: Paul Sebastian <[email protected]> * include some constants for specific time choices Signed-off-by: Paul Sebastian <[email protected]> * changed naming of some constants Signed-off-by: Paul Sebastian <[email protected]> * fix search test Signed-off-by: Paul Sebastian <[email protected]> * change back query slice Signed-off-by: Paul Sebastian <[email protected]> * failing snapshot updated after merge with main Signed-off-by: Paul Sebastian <[email protected]> --------- Signed-off-by: Paul Sebastian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There is an unresolved issue where while query assistant is enabled, and a query is generated and run using query assistant, it'll use the 15 minute time constraint instead of the 40 years. However, this issue goes away when clicking on the run button again. Fix pending.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.