Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures from query assistant #1360

Merged

Conversation

paulstn
Copy link
Collaborator

@paulstn paulstn commented Jan 12, 2024

Note: There is an unresolved issue where while query assistant is enabled, and a query is generated and run using query assistant, it'll use the 15 minute time constraint instead of the 40 years. However, this issue goes away when clicking on the run button again. Fix pending.

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 294 lines in your changes are missing coverage. Please review.

Comparison is base (6682b02) 52.92% compared to head (a231126) 53.06%.
Report is 97 commits behind head on main.

Files Patch % Lines
public/components/custom_panels/helpers/utils.tsx 13.51% 64 Missing ⚠️
public/components/common/search/search.tsx 40.20% 58 Missing ⚠️
...ts/event_analytics/explorer/query_assist/input.tsx 75.58% 20 Missing and 1 partial ⚠️
public/components/event_analytics/utils/utils.tsx 5.00% 19 Missing ⚠️
public/components/common/search/query_area.tsx 0.00% 17 Missing ⚠️
...mponents/event_analytics/hooks/use_fetch_events.ts 5.88% 16 Missing ⚠️
public/components/metrics/sidebar/sidebar.tsx 55.55% 16 Missing ⚠️
...vent_analytics/explorer/events_views/data_grid.tsx 40.00% 15 Missing ⚠️
...nents/common/search/query_assist_summarization.tsx 0.00% 10 Missing ⚠️
...c/components/metrics/redux/slices/metrics_slice.ts 68.00% 8 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1360      +/-   ##
==========================================
+ Coverage   52.92%   53.06%   +0.14%     
==========================================
  Files         302      312      +10     
  Lines       10587    11115     +528     
  Branches     2777     2899     +122     
==========================================
+ Hits         5603     5898     +295     
- Misses       4939     5169     +230     
- Partials       45       48       +3     
Flag Coverage Δ
dashboards-observability 53.06% <54.83%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
@paulstn paulstn requested a review from joshuali925 January 16, 2024 18:16
@paulstn paulstn merged commit d741ed4 into opensearch-project:main Jan 16, 2024
12 of 20 checks passed
@joshuali925 joshuali925 mentioned this pull request Jan 18, 2024
6 tasks
paulstn added a commit to paulstn/dashboards-observability that referenced this pull request Jan 22, 2024
* turned 40 year defaults into dependent on query assistant

Signed-off-by: Paul Sebastian <[email protected]>

* fix search test, undefined handling

Signed-off-by: Paul Sebastian <[email protected]>

* include some constants for specific time choices

Signed-off-by: Paul Sebastian <[email protected]>

* changed naming of some constants

Signed-off-by: Paul Sebastian <[email protected]>

* fix search test

Signed-off-by: Paul Sebastian <[email protected]>

* change back query slice

Signed-off-by: Paul Sebastian <[email protected]>

* failing snapshot updated after merge with main

Signed-off-by: Paul Sebastian <[email protected]>

---------

Signed-off-by: Paul Sebastian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants