Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(query assist) support option to disable summary #1376

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Jan 19, 2024

Description

This PR makes summary configurable. If it's disabled (default), error responses will show in an error toast. If it's enabled, it extracts the raw PPL from PPL tool's error (this is a workaround for opensearch-project/skills#138), then uses the summarize agent to show a summary.

sample configs

with summary

observability.query_assist.enabled: true
observability.query_assist.ppl_agent_name: "PPL agent"
observability.summarize.enabled: true
observability.summarize.response_summary_agent_name: "Response summary agent"
observability.summarize.error_summary_agent_name: "Error summary agent"

without summary

observability.query_assist.enabled: true
observability.query_assist.ppl_agent_name: "PPL agent"

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (8f1f83a) 53.86% compared to head (1c76442) 53.88%.

Files Patch % Lines
...ts/event_analytics/explorer/query_assist/input.tsx 63.63% 4 Missing ⚠️
...onents/event_analytics/hooks/use_fetch_patterns.ts 0.00% 2 Missing ⚠️
.../event_analytics/hooks/use_fetch_visualizations.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
+ Coverage   53.86%   53.88%   +0.01%     
==========================================
  Files         316      316              
  Lines       11309    11308       -1     
  Branches     2955     2957       +2     
==========================================
+ Hits         6092     6093       +1     
+ Misses       5169     5167       -2     
  Partials       48       48              
Flag Coverage Δ
dashboards-observability 53.88% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Joshua Li <[email protected]>
@joshuali925 joshuali925 changed the title (query assist) extract ppl from error response (query assist) support option to disable summary Jan 22, 2024
Signed-off-by: Joshua Li <[email protected]>
@joshuali925 joshuali925 added the enhancement New feature or request label Jan 22, 2024
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
@joshuali925 joshuali925 merged commit 473edac into opensearch-project:main Jan 23, 2024
14 of 20 checks passed
sejli pushed a commit to sejli/dashboards-observability that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants