Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(query assist) enforce timerange to QUERY_ASSIST_START_TIME #1379

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

joshuali925
Copy link
Member

Description

Set timerange to be consistent as showed on UI

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@paulstn paulstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (473edac) 53.88% compared to head (f2dcae4) 53.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
- Coverage   53.88%   53.87%   -0.01%     
==========================================
  Files         316      316              
  Lines       11308    11309       +1     
  Branches     2957     2957              
==========================================
  Hits         6093     6093              
- Misses       5167     5168       +1     
  Partials       48       48              
Flag Coverage Δ
dashboards-observability 53.87% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuali925 joshuali925 added the bug Something isn't working label Jan 23, 2024
@joshuali925 joshuali925 mentioned this pull request Jan 23, 2024
6 tasks
@joshuali925 joshuali925 merged commit f2962ef into opensearch-project:main Jan 23, 2024
14 of 22 checks passed
sejli pushed a commit to sejli/dashboards-observability that referenced this pull request Jan 26, 2024
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
…ect#1450) (opensearch-project#1477)

* Replace legacy template with index template (opensearch-project#1359)

Signed-off-by: Chang Liu <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* added loginEndPointWithPath (opensearch-project#1358)

* added loginEndPointWithPath
Signed-off-by: Mattijs Vanhaverbeke <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Add release notes for 1.3.9 (opensearch-project#1379)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* No blank backend role before adding a new one in Create User page (opensearch-project#1384)

* Add last backend role empty check

Signed-off-by: nursaadat <[email protected]>
Signed-off-by: Saadat Nursultan <[email protected]>

* Add backend role empty check

Signed-off-by: nursaadat <[email protected]>
Signed-off-by: Saadat Nursultan <[email protected]>

* Add strict comparison

Signed-off-by: nursaadat <[email protected]>
Signed-off-by: Saadat Nursultan <[email protected]>

* Fix lint errors

Signed-off-by: nursaadat <[email protected]>
Signed-off-by: Saadat Nursultan <[email protected]>

* Add tests for backend role panel

Signed-off-by: Saadat Nursultan <[email protected]>

* Fix lint errors

Signed-off-by: Saadat Nursultan <[email protected]>

---------

Signed-off-by: nursaadat <[email protected]>
Signed-off-by: Saadat Nursultan <[email protected]>
Co-authored-by: nursaadat <[email protected]>
Co-authored-by: Saadat Nursultan <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Fix script for Windows (opensearch-project#1393)

* Fix script for Windows

Signed-off-by: nurbqq <[email protected]>
Signed-off-by: nurbqq <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding new actions for ppl and datasource apis (opensearch-project#1395)

* Adding new actions for ppl and datasource apis

Signed-off-by: vamsi-amazon <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Fix "Get started" image is not adaptive to the browser window size. (opensearch-project#1396)

* Fixed get-started page image not adapting to the browser window size

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Update fix by applying suggested changes

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Update unit tests snapshot

Signed-off-by: Sirazh Gabdullin <[email protected]>

---------

Signed-off-by: Sirazh Gabdullin <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Split up a value into multiple cookie payloads (opensearch-project#1352)

* PoC for splitting up a value into multiple cookie payloads

Signed-off-by: Jochen Kressin <[email protected]>

* Cookie splitting for OpenId and SAML

Signed-off-by: Jochen Kressin <[email protected]>

* Changes after review comments

Signed-off-by: Jochen Kressin <[email protected]>

* WIP: First unit tests

Signed-off-by: Jochen Kressin <[email protected]>

* More unit tests

Signed-off-by: Jochen Kressin <[email protected]>

* Fix for multi auth, request argument was missing

Signed-off-by: Jochen Kressin <[email protected]>

* Fixed linting errors

Signed-off-by: Jochen Kressin <[email protected]>

* Added one additional cookie for the SAML integration tests

Signed-off-by: Jochen Kressin <[email protected]>

---------

Signed-off-by: Jochen Kressin <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Dynamic tenancy configurations (opensearch-project#1394)

* Dynamic multitenancy feature.

Signed-off-by: Abhi Kalra <[email protected]>

* Dynamic multitenancy feature -PR feedback

Signed-off-by: Abhi Kalra <[email protected]>

---------

Signed-off-by: Abhi Kalra <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Add release notes for 2.7.0 (opensearch-project#1407)

* Add release notes for 2.7.0

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removes tiny.amazon.com links (opensearch-project#1420)

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Fixing dynamic tenancy changes for issues 1412 (opensearch-project#1419)

* Fixing dynamic tenancy changes for opensearchdasbhoard.yaml

Signed-off-by: Abhi Kalra <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Change the testuser's password in some integration test cases into a stronger password (opensearch-project#1428)

* Change the testuser's password into a stronger password

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Increment version to 3.0.0.0 (opensearch-project#1414)

Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adds the newly created admin api permissions to the static dropdown list (opensearch-project#1426)

* Adds the newly created admin api permissions to the static dropdown of permissions displayed when creating/modifying a role

---------

Signed-off-by: Darshit Chanpura <[email protected]>
Co-authored-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update account-nav-button.tsx

Fix added to set the window.location to the pathname, rather than just reload & clear lastURL as it would be from the previous tenant.

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update account-nav-button.tsx

Adding comments to explain changes

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* add new cluster permissions constants for lron (opensearch-project#1444)

Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* removing whitespace due to linting fix

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests for account-nav-button wip

Signed-off-by: leanneeliatra <[email protected]>

* put commented code to original state

Signed-off-by: leanneeliatra <[email protected]>

* Skip flaky SAML test as it awaits a fix (opensearch-project#1453)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Use version from package.json for integration tests (opensearch-project#1463)

* Use version from package.json for integration tests

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adds 2.8 release notes (opensearch-project#1464)

Signed-off-by: Darshit Chanpura <[email protected]>
Co-authored-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests to jest test for tenant switch. Putting test in correct folder and renaming function.
Signed-off-by: leanneeliatra <[email protected]>

Signed-off-by: leanneeliatra <[email protected]>

* handle switch calling correct function

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* checking for session storage
Signed-off-by: leanneeliatra <[email protected]>

Signed-off-by: leanneeliatra <[email protected]>

* adding window to make sessionStorage more explicit

Signed-off-by: leanneeliatra <[email protected]>

* Moved the test into account-nav-button.test.tsx

Signed-off-by: leanneeliatra <[email protected]>

* Removing additional files.

Signed-off-by: leanneeliatra <[email protected]>

* Declared session storage as a constant

Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update account-nav-button.tsx

Fix added to set the window.location to the pathname, rather than just reload & clear lastURL as it would be from the previous tenant.

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update account-nav-button.tsx

Adding comments to explain changes

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* removing whitespace due to linting fix

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests for account-nav-button wip

Signed-off-by: leanneeliatra <[email protected]>

* put commented code to original state

Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests to jest test for tenant switch. Putting test in correct folder and renaming function.
Signed-off-by: leanneeliatra <[email protected]>

Signed-off-by: leanneeliatra <[email protected]>

* handle switch calling correct function

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing additional files.

Signed-off-by: leanneeliatra <[email protected]>

* Fix unwanted changes

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update account-nav-button.tsx

Fix added to set the window.location to the pathname, rather than just reload & clear lastURL as it would be from the previous tenant.

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests for account-nav-button wip

Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests to jest test for tenant switch. Putting test in correct folder and renaming function.
Signed-off-by: leanneeliatra <[email protected]>

Signed-off-by: leanneeliatra <[email protected]>

* checking for session storage
Signed-off-by: leanneeliatra <[email protected]>

Signed-off-by: leanneeliatra <[email protected]>

* Declared session storage as a constant

Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests for account-nav-button wip

Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests to jest test for tenant switch. Putting test in correct folder and renaming function.
Signed-off-by: leanneeliatra <[email protected]>

Signed-off-by: leanneeliatra <[email protected]>

* Moved the test into account-nav-button.test.tsx

Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Dynamic tenancy configurations (opensearch-project#1394)

* Dynamic multitenancy feature.

Signed-off-by: Abhi Kalra <[email protected]>

* Dynamic multitenancy feature -PR feedback

Signed-off-by: Abhi Kalra <[email protected]>

---------

Signed-off-by: Abhi Kalra <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Fixing dynamic tenancy changes for issues 1412 (opensearch-project#1419)

* Fixing dynamic tenancy changes for opensearchdasbhoard.yaml

Signed-off-by: Abhi Kalra <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Use version from package.json for integration tests (opensearch-project#1463)

* Use version from package.json for integration tests

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing unneded file

Signed-off-by: leanneeliatra <[email protected]>

---------

Signed-off-by: Chang Liu <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: nursaadat <[email protected]>
Signed-off-by: Saadat Nursultan <[email protected]>
Signed-off-by: nurbqq <[email protected]>
Signed-off-by: nurbqq <[email protected]>
Signed-off-by: vamsi-amazon <[email protected]>
Signed-off-by: Sirazh Gabdullin <[email protected]>
Signed-off-by: Jochen Kressin <[email protected]>
Signed-off-by: Abhi Kalra <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: opensearch-ci-bot <[email protected]>
Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Chang Liu <[email protected]>
Co-authored-by: mattieserver <[email protected]>
Co-authored-by: Ryan Liang <[email protected]>
Co-authored-by: Saadat Nursultan <[email protected]>
Co-authored-by: nursaadat <[email protected]>
Co-authored-by: Saadat Nursultan <[email protected]>
Co-authored-by: Nurbakhyt Sembayev <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
Co-authored-by: Vamsi Manohar <[email protected]>
Co-authored-by: Sirazh Gabdullin <[email protected]>
Co-authored-by: Jochen Kressin <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <[email protected]>
Co-authored-by: zhichao-aws <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
(cherry picked from commit 7f4e0f29f11668b09c5343da2cbc97ac1d6d0acf)

Co-authored-by: leanneeliatra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants