Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default CI Java Version to Java 11, run tests on 8, 14 and 17 #320

Closed
3 tasks
Tracked by #64
dblock opened this issue Nov 17, 2021 · 4 comments · Fixed by #395 or #418
Closed
3 tasks
Tracked by #64

Default CI Java Version to Java 11, run tests on 8, 14 and 17 #320

dblock opened this issue Nov 17, 2021 · 4 comments · Fixed by #395 or #418
Labels
v1.3.0

Comments

@dblock
Copy link
Member

dblock commented Nov 17, 2021

Coming from opensearch-project/opensearch-plugins#64, default CI Java version to 11 (LTS), and run tests on 8, 14 and 17.

  • Change the default Java version for CI in GitHub actions from 14/15 to 11 (LTS).
  • Add Java 8, 14 (used before), and 17 (next LTS) to the CI matrix.
  • Document Java versions in DEVELOPER_GUIDE.md.
@dblock dblock mentioned this issue Nov 17, 2021
Closed
15 tasks
@ohltyler ohltyler mentioned this issue Feb 10, 2022
Closed
kaituo added a commit to kaituo/anomaly-detection-1 that referenced this issue Feb 10, 2022
@kaituo
Change to compile protostuff using jdk 11
466646b 
Previously, I built protostuff using JDK 14 and upgraded protostuff. 1.3.0 build started failing afterwards (logs here: opensearch-project/opensearch-build#1613), maybe because Jenkins uses JDK 11 (read opensearch-project#320).  This PR rebuilt protostuff using JDK 11.

Testing done:
1. Tested both single-stream and HCAD real-time detectors.
kaituo added a commit to kaituo/anomaly-detection-1 that referenced this issue Feb 10, 2022
@kaituo
Change to compile protostuff using jdk 11
12ca475 
Previously, I built protostuff using JDK 14 and upgraded protostuff. 1.3.0 build started failing afterwards (logs here: opensearch-project/opensearch-build#1613), maybe because Jenkins uses JDK 11 (read opensearch-project#320).  This PR rebuilt protostuff using JDK 11.

Testing done:
1. Tested both single-stream and HCAD real-time detectors.
kaituo added a commit to kaituo/anomaly-detection-1 that referenced this issue Feb 10, 2022
@kaituo
Change to compile protostuff using jdk 11
a4b0f24 
Previously, I built protostuff using JDK 14 and upgraded protostuff. 1.3.0 build started failing afterwards (logs here: opensearch-project/opensearch-build#1613), maybe because Jenkins uses JDK 11 (read opensearch-project#320).  This PR rebuilt protostuff using JDK 11.

Testing done:
1. Tested both single-stream and HCAD real-time detectors.

Signed-off-by: Kaituo Li <[email protected]>
@kaituo kaituo mentioned this issue Feb 10, 2022
Merged
1 task
kaituo added a commit that referenced this issue Feb 10, 2022
@kaituo
Change to compile protostuff using jdk 11 (#374)
a79028f 
Previously, I built protostuff using JDK 14 and upgraded protostuff. 1.3.0 build started failing afterwards (logs here: opensearch-project/opensearch-build#1613), maybe because Jenkins uses JDK 11 (read #320).  This PR rebuilt protostuff using JDK 11.

Testing done:
1. Tested both single-stream and HCAD real-time detectors.

Signed-off-by: Kaituo Li <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Mar 2, 2022
@kaituo @github-actions
Change to compile protostuff using jdk 11 (#374)
a23d762 
Previously, I built protostuff using JDK 14 and upgraded protostuff. 1.3.0 build started failing afterwards (logs here: opensearch-project/opensearch-build#1613), maybe because Jenkins uses JDK 11 (read #320).  This PR rebuilt protostuff using JDK 11.

Testing done:
1. Tested both single-stream and HCAD real-time detectors.

Signed-off-by: Kaituo Li <[email protected]>
(cherry picked from commit a79028f)
ohltyler pushed a commit that referenced this issue Mar 2, 2022
@kaituo @ohltyler
Change to compile protostuff using jdk 11 (#374)
12bfa05 
Previously, I built protostuff using JDK 14 and upgraded protostuff. 1.3.0 build started failing afterwards (logs here: opensearch-project/opensearch-build#1613), maybe because Jenkins uses JDK 11 (read #320).  This PR rebuilt protostuff using JDK 11.

Testing done:
1. Tested both single-stream and HCAD real-time detectors.

Signed-off-by: Kaituo Li <[email protected]>
(cherry picked from commit a79028f)
@ohltyler ohltyler mentioned this issue Mar 2, 2022
Merged
1 task
@dblock
Copy link
Member Author

dblock commented Mar 9, 2022

@ohltyler You still need to build on JDK 8

@dblock dblock reopened this Mar 9, 2022
@ohltyler
Copy link
Member

ohltyler commented Mar 9, 2022

@dblock I thought 8 became optional. We had encountered some failures building with it:

11 = must, 8 = should, 14 and 17 = nice to have

@ohltyler
Copy link
Member

ohltyler commented Mar 9, 2022

What about JDK17? We also had problems with that one. Is that still optional? Is this issue out of date?

@ohltyler ohltyler mentioned this issue Mar 9, 2022
Closed
1 task
@ohltyler
Copy link
Member

ohltyler commented Mar 9, 2022

@dblock there's problems doing this with JDK8 - details in #409

@dblock dblock removed the untriaged label Mar 10, 2022
@dblock dblock mentioned this issue Mar 10, 2022
Merged
1 task
hamersu9t added a commit to hamersu9t/anomaly-detection that referenced this issue Aug 10, 2024
@hamersu9t
Change to compile protostuff using jdk 11 (#374)
54f505d 
Previously, I built protostuff using JDK 14 and upgraded protostuff. 1.3.0 build started failing afterwards (logs here: opensearch-project/opensearch-build#1613), maybe because Jenkins uses JDK 11 (read opensearch-project/anomaly-detection#320).  This PR rebuilt protostuff using JDK 11.

Testing done:
1. Tested both single-stream and HCAD real-time detectors.

Signed-off-by: Kaituo Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v1.3.0
Projects
None yet
Milestone
No milestone
2 participants
@dblock @ohltyler